feat: handle suggestion click

[mamadoudicko]

#1367

This is the first part of the system. We'll update how we fetch this 'assistant' response soon

Screen.Recording.2023-10-09.at.18.22.09.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2023 7:37am
quivr-strapi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2023 7:37am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2023 7:37am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/components/OnboardingQuestions/components/OnboardingQuestion/OnboardingQuestion.tsx

The changes in this file are generally safe, but there is a potential issue with the onClick handler. The void keyword is used, which forces the function to return undefined. This is not necessary and could lead to confusion. Instead, the onClick handler could be written as follows:

onClick={handleSuggestionClick}

This would make the code cleaner and easier to understand.

---

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/hooks/useOnboarding.ts

The changes in this file are generally safe, but there is a potential issue with the useQuery hook. The queryFn is set to getOnboarding, but no dependencies are provided in the queryKey array. If getOnboarding depends on any external variables, they should be included in the queryKey array to ensure the query is re-run when they change.

---

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/components/OnboardingQuestions/components/OnboardingQuestion/hooks/useOnboardingQuestion.ts

The changes in this file are generally safe, but there is a potential issue with the handleSuggestionClick function. It uses Promise.all without any error handling. If either addQuestion or updateOnboarding fails, the other will still execute and the error will be unhandled. Consider adding a try/catch block to handle any potential errors.

---

🖱️🔍🐛

---

Powered by Code Review GPT