Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove user onboarding on complete #1387

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat: remove user onboarding on complete #1387

merged 1 commit into from
Oct 11, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Oct 10, 2023 •
edited

#1384

Screen.Recording.2023-10-10.at.18.20.27.mov

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Oct 10, 2023
@mamadoudicko mamadoudicko temporarily deployed to preview October 10, 2023 16:04 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 4:26pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 4:26pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 4:26pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/hooks/useOnboarding.ts

The code changes involve the modification of the useOnboarding hook. The hook now fetches onboarding data using a query and updates it. Ensure that the query is correctly formed and that error handling is in place for failed queries. Also, ensure that the updateOnboarding function is correctly updating the state.

Risk Level 2 - /home/runner/work/quivr/quivr/backend/repository/onboarding/update_user_onboarding.py

The code changes involve the addition of a new function update_user_onboarding. This function updates user onboarding information and removes it if all values are False. Ensure that the removal operation is performed carefully to avoid accidental data loss. Consider adding error handling or confirmation prompts before data deletion.

Risk Level 2 - /home/runner/work/quivr/quivr/backend/models/databases/supabase/onboarding.py

The code changes involve the addition of a new method remove_user_onboarding to the Onboarding class. This method deletes user onboarding data from the database. Ensure that this operation is performed carefully to avoid accidental data loss. Consider adding error handling or confirmation prompts before data deletion.

🔍📝🚫

Powered by Code Review GPT

@mamadoudicko mamadoudicko temporarily deployed to preview October 10, 2023 16:21 — with GitHub Actions Inactive
gozineb
gozineb approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gozineb gozineb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thnks mamadz

@mamadoudicko mamadoudicko merged commit 1baf9ee into main Oct 11, 2023
11 of 12 checks passed
@StanGirard StanGirard mentioned this pull request Oct 11, 2023
Merged
gozineb pushed a commit that referenced this pull request Oct 11, 2023
@StanGirard
chore(main): release 0.0.90 (#1371)
5503e10 
🤖 I have created a release *beep* *boop*
---


## 0.0.90 (2023-10-11)

## What's Changed
* feat: add Welcome chat by @mamadoudicko in
#1365
* feat: handle suggestion click by @mamadoudicko in
#1368
* refactor: Enable linting on login+signup page and hooks by
@matthieujacq in #1369
* feat: finish onboarding step on first upload or crawl by @mamadoudicko
in #1373
* feat: add create_user_onboarding_function by @mamadoudicko in
#1383
* feat: remove user onboarding on complete by @mamadoudicko in
#1387


**Full Changelog**:
v0.0.89...v0.0.90

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
@coolCatalyst
chore(main): release 0.0.90 (#1371)
47982a6 
🤖 I have created a release *beep* *boop*
---


## 0.0.90 (2023-10-11)

## What's Changed
* feat: add Welcome chat by @mamadoudicko in
QuivrHQ/quivr#1365
* feat: handle suggestion click by @mamadoudicko in
QuivrHQ/quivr#1368
* refactor: Enable linting on login+signup page and hooks by
@matthieujacq in QuivrHQ/quivr#1369
* feat: finish onboarding step on first upload or crawl by @mamadoudicko
in QuivrHQ/quivr#1373
* feat: add create_user_onboarding_function by @mamadoudicko in
QuivrHQ/quivr#1383
* feat: remove user onboarding on complete by @mamadoudicko in
QuivrHQ/quivr#1387


**Full Changelog**:
QuivrHQ/quivr@v0.0.89...v0.0.90

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gozineb gozineb gozineb approved these changes

Assignees
No one assigned
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mamadoudicko @gozineb