fix(streaming): Data Truncation Issue in useHandleStream Function #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
Someone is attempting to deploy a commit to the Quivr-app Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
area: frontend
StanGirard
approved these changes
Jan 26, 2024
StanGirard
approved these changes
Jan 26, 2024
StanGirard
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
StanGirard
changed the title
StanGirard
added a commit
that referenced
this pull request
Jan 26, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.184 (2024-01-26) ## What's Changed * feat(panel): added by @Zewed in #2088 * feat: 🎸 api by @StanGirard in #2078 * fix(frontend): clear message input on submit by @Zewed in #2087 * fix: 🐛 related by @StanGirard in #2090 * feat: Added translation status badge from inlang by @NilsJacobsen in #2080 * fix(streaming): Data Truncation Issue in useHandleStream Function by @openperf in #2079 * feat: 🎸 sources by @StanGirard in #2092 * fix(frontend): clean related Brains useEffect by @Zewed in #2091 ## New Contributors * @openperf made their first contribution in #2079 **Full Changelog**: v0.0.183...v0.0.184 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces modifications to the useHandleStream function in the useHandleStream.ts file, aiming to resolve the issue of data truncation leading to incomplete display of Q&A on the front end. By optimizing data handling logic and enhancing error management, this change ensures the integrity of data streams and accurate display on the front end.
Changes Made
Introduced a variable incompleteData to store and process incomplete data fragments.
Implemented logic to concatenate incomplete data with new chunks and parse them once complete.
Added error handling to gracefully manage the parsing of incomplete data and data strings.
Improved the handling of the first data chunk, enhancing the coherence of data processing.
Motivation and Context
The primary motivation for these changes is to address the issue of incomplete front-end display, caused by data stream truncation under unstable network conditions. This optimization is intended to enhance the stability and reliability of the application when handling large volumes of real-time data streams, ensuring that the user interface correctly displays complete Q&A information.
Checklist before requesting a review
My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented in hard-to-understand areas of my code.
I have made corresponding changes to the documentation (if applicable).
I have added tests that prove my fix is effective or that my feature works (if applicable).
New and existing unit tests pass locally with my changes.
Any dependent changes have been merged and published in downstream modules (if applicable).
Screenshots (if appropriate)