Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): clean related Brains useEffect #2091

Merged
merged 4 commits into from
Jan 26, 2024
Merged

fix(frontend): clean related Brains useEffect #2091

merged 4 commits into from
Jan 26, 2024

Conversation

Zewed
Copy link
Collaborator

@Zewed Zewed commented Jan 26, 2024

Description

  • Select current Brain from brain_id instead of brain_name
  • Avoid multiple calls of useEffect

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 26, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 2:16am

@dosubot dosubot bot added area: frontend Related to frontend functionality or under the /frontend directory autorelease: pending labels Jan 26, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 26, 2024
@StanGirard StanGirard merged commit 67c71bb into main Jan 26, 2024
4 of 5 checks passed
@StanGirard StanGirard mentioned this pull request Jan 26, 2024
Merged
StanGirard added a commit that referenced this pull request Jan 26, 2024
@StanGirard
chore(main): release 0.0.184 (#2089)
64ba190 
🤖 I have created a release *beep* *boop*
---


## 0.0.184 (2024-01-26)

## What's Changed
* feat(panel): added by @Zewed in
#2088
* feat: 🎸 api by @StanGirard in
#2078
* fix(frontend): clear message input on submit by @Zewed in
#2087
* fix: 🐛 related by @StanGirard in
#2090
* feat: Added translation status badge from inlang by @NilsJacobsen in
#2080
* fix(streaming): Data Truncation Issue in useHandleStream Function by
@openperf in #2079
* feat: 🎸 sources by @StanGirard in
#2092
* fix(frontend): clean related Brains useEffect by @Zewed in
#2091

## New Contributors
* @openperf made their first contribution in
#2079

**Full Changelog**:
v0.0.183...v0.0.184

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: frontend Related to frontend functionality or under the /frontend directory autorelease: pending size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zewed @StanGirard