-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: streaming for standard brain picking #385
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2a1b576
to
21d3ff8
Compare
Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com>
…mc/sse-response-streaming
Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove brainpicking.cpython
backend/vectorstore/supabase.py
Outdated
@@ -25,6 +25,7 @@ def __init__( | |||
def similarity_search( | |||
self, | |||
query: str, | |||
user_id: str = "none", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the big we previously had with the documents? I'll check it out today anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove cpython file
- Explain or remove supabase.py str for user_id.
Else looks good <3
Test and build work
const currentChatId = chatId; | ||
const chatHistory = await getChatHistory(currentChatId); | ||
|
||
if (chatId === currentChatId && chatHistory.length > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to understand what is happening here:
const currentChatId = chatId;
if(chatId === currentChatId)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair :) that's dead. I think I didnt spot the line above.
@@ -0,0 +1,13 @@ | |||
export const generateUUID = (): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can now be removed i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes definitely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @mattzcarey !
Few low Loggaf returns but LGFM!
* feat: streaming for standard brain picking * fix(bug): private llm * wip: test Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com> * wip: almost good Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com> * feat: useFetch * chore: remove 💀 * chore: fix linting * fix: forward the request if not streaming * feat: streaming for standard brain picking * fix(bug): private llm * wip: test Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com> * wip: almost good Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com> * feat: useFetch * chore: remove 💀 * chore: fix linting * fix: forward the request if not streaming * fix: 💀 code * fix: check_user_limit * feat: brain_id to new chat stream * fix: missing imports * feat: message_id created on backend Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com> * chore: remove dead * remove: cpython * remove: dead --------- Co-authored-by: Mamadou DICKO <mamadoudicko@users.noreply.github.com>
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Standard brain picking (BE)
Frontend
TODO: OpenAI function future PR
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):