fix/reconnecting #191

OchirDarmaev · 2020-08-20T09:53:02Z

Reconnecting не запускается в некоторых случаях

При вызове Reconnect() флаг Reconnecting = true, что не позволяет выполнить Reconnect()

Причина не запуска Reconnect()

Попытка реконнекта Manager.Reconnect() использует флаг "Reconnecting", если есть текущая попытка, последующие отбиваются
Manager.Reconnect() выставляет Reconnecting = true, планирует задачу реконнекта
задача реконнекта по завершению сбрасывает флаг Reconnecting

Почему не запускается Reconnect() ?

Внутри Manager, при вызове OnClose(), запускается очистка всех задач,
Если была запланирована задача реконнекта, также зачищается.

Т.е. флаг Reconnecting больше не будет сброшен, и последующие Manager.Reconnect() не будут выполнены т.к. нужен Reconnecting == false для запуска задачи.

2020-08-19 18:33:27 327 [] SocketIoClientDotNet-Manager.cs:OnClose#428 start
2020-08-19 18:33:27 329 [] SocketIoClientDotNet-Socket.cs:OnClose#215 close (ping timeout)
2020-08-19 18:33:27 330 [] SocketIoClientDotNet-Socket.cs:OnClose#215 close (ping timeout)
2020-08-19 18:33:27 330 [] SocketIoClientDotNet-Socket.cs:OnClose#215 close (ping timeout)
2020-08-19 18:33:27 331 [] SocketIoClientDotNet-Manager.cs:OnClose#428 _reconnection= True
2020-08-19 18:33:27 332 [] SocketIoClientDotNet-Manager.cs:OnClose#428 SkipReconnect= False
2020-08-19 18:33:27 332 [] SocketIoClientDotNet-Manager.cs:OnClose#428 reconnect= True
2020-08-19 18:33:27 332 [] SocketIoClientDotNet-Manager.cs:Reconnect#463 Reconnecting= True
2020-08-19 18:33:27 332 [] SocketIoClientDotNet-Manager.cs:Reconnect#463 SkipReconnect= False

* Support binary data in Emit with Ack * Support Action<T1, T2, T3, T4> in AckImpl

…parameter in Emit(sring, params object[]) (Quobject#118)

Will be pushed to nuget in next release: 2 July 2018

) var socket = IO.Socket("http://localhost:3000"); socket.On("connect", () => { _log.Write($"Connected !"); var login = new { name = "juanlu", password = "123456" }; socket.Emit("login", login); });

…uobject#164)

Quobject#166)

…yParams wused to be included in namespace. Path should only be included in namespace. (Quobject#179)

fix for not updating Managers when new instance added

OchirDarmaev · 2020-08-21T15:02:50Z

Hello, @mattqs if I will create a properly merge request do you merge it?

mattqs · 2020-08-21T20:54:43Z

I don't have any reconnecting problems.

This is the Socket.IO Client Library for C#, which is ported from the JavaScript client version 1.1.0.
It is not meant to be working for a later version (it does not work for version 2.0).

If you want a version later than 1.1.0, please fork and publish it to Nuget under a new name and leave a comment with a link.

Quobject/EngineIoClientDotNet#69

hypernoob and others added 18 commits September 16, 2017 09:11

Support binary data in Emit with Ack (Quobject#117)

1655bb5

* Support binary data in Emit with Ack * Support Action<T1, T2, T3, T4> in AckImpl

Fix ArgumentException thrown by Args2JArray when AckImpl is the last …

c4b0d68

…parameter in Emit(sring, params object[]) (Quobject#118)

1.0.3

75c389d

1.0.4

d0d98db

1.0.5

54af19e

1.0.6

c85148b

Fix #147: no socket for namespace undefined (Quobject#148)

dc3ceb1

Will be pushed to nuget in next release: 2 July 2018

Bug Fixed. Now you can use correctly Emit, passing params. (Quobject#150

49cc478

) var socket = IO.Socket("http://localhost:3000"); socket.On("connect", () => { _log.Write($"Connected !"); var login = new { name = "juanlu", password = "123456" }; socket.Emit("login", login); });

1.0.7

4c955fc

1.0.7.1

f213381

replaced JsonParser with JsonConvert to allow parsing custom types (Q…

36d24ac

…uobject#164)

Added EVENT_ENGINE which is fired when a new engine socket is created. (

a52bdf0

Quobject#166)

Everything fails

853292c

fix for wrong namespace creation: if using uri with queryParams, quer…

3736596

…yParams wused to be included in namespace. Path should only be included in namespace. (Quobject#179)

use .net sdk project and multi-target (Quobject#181)

2506dd5

update Managers when new instance added (Quobject#182)

988b88c

fix for not updating Managers when new instance added

1.0.8

e877c1d

fix Reconnecting state

6672202

OchirDarmaev force-pushed the fix/reconnecting branch from e38556d to 6672202 Compare August 20, 2020 11:22

mattqs closed this Aug 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix/reconnecting #191

fix/reconnecting #191

OchirDarmaev commented Aug 20, 2020

OchirDarmaev commented Aug 21, 2020

mattqs commented Aug 21, 2020

fix/reconnecting #191

fix/reconnecting #191

Conversation

OchirDarmaev commented Aug 20, 2020

OchirDarmaev commented Aug 21, 2020

mattqs commented Aug 21, 2020