-
Notifications
You must be signed in to change notification settings - Fork 350
Conversation
* Homebrew is currently production state for openssl e.g. runtimes, snapshots, or whatever other synonym is used * Add some error protection if neither are found. * Precedence is production *(pro)* then development *(dev)* Post followup for QupZilla#1971
This isn't quite ready |
Do we really want it? I think requiring |
If anyone gets into developing/testing openssl and needs a test platform instead of the prebuilt install binaries then yes. This is a minor glitch as most people won't be deleting their openssl with brew and/or ssl linkage but I usually do forward and reverse regression testings just to be sure. I'm still a bit green on current .pro and haven't found a variable that tells me which target definition it's in. That's all I really need to remove the glitch... alternatively I could just not Some of QupZilla's https errors could possibly be attributed to a ssl bug ... so a good way to test is allow the dev side of openssl. |
…ence * Qt 5.6 doesn't appear to support any other scopes other than `debug` and `release` * Nothing I could find in `.../mkspecs` that was applicable * Predefined targets don't seem to have a `build` or `clean` phase state * Qt `system` calls don't appear to have access to `MAKECMDGOALS` * Qt `QMAKE_EXTRA_TARGETS` could possibly work if the environment scope was the same... see prior list item So basically at this time it is an unsupported feature in current Qt... so get to wait until something else pops up or newer functionality. It is still a good idea to allow dev testing with openssl under Mac ... otherwise it's saying Linux and Windows can test `master` on openssl but Mac users can't.
I'd have to modify/contribute to Qt directly in order to get some scopes in here that would allow termination of the build process (e.g. P.S. Travis does build... seems their test system is busted at the moment... The command "if [[ "$QT" == "qt56" ]]; then sudo apt-add-repository -y ppa:beineri/opt-qt56-trusty; sudo apt-get update -qq; sudo apt-get install -qq qt56tools qt56script qt56webengine qt56webchannel qt56declarative qt56x11extras; fi" failed and exited with 100 during . ... wasn't busted yesterday and it was passing. Builds fine here on mac dev station. Opted for existing inconvenience of breaking out of it or having it fail on compile.... instead of breaking |
$ brew upgrade openssl
...
Error: openssl 1.0.2k already installed Ref: |
Closing from lack of interest. |
errorwarning protection if neither are found.Post followup for #1971
PR READY