Skip to content
This repository has been archived by the owner on May 10, 2018. It is now read-only.

Mac: Allow developer openssl configs #1979

Closed
wants to merge 2 commits into from

Conversation

Martii
Copy link
Contributor

@Martii Martii commented May 16, 2016

Post followup for #1971


PR READY

* Homebrew is currently production state for openssl e.g. runtimes, snapshots, or whatever other synonym is used
* Add some error protection if neither are found.
* Precedence is production *(pro)* then development *(dev)*

Post followup for QupZilla#1971
@Martii
Copy link
Contributor Author

Martii commented May 16, 2016

This isn't quite ready make distclean failed when both are absent by removal... not sure this is fixable, or needs to be, but I'll have a go at it.

@nowrep
Copy link
Member

nowrep commented May 16, 2016

Do we really want it? I think requiring brew is enough, after all it's de facto standard to have it on your Mac.

@Martii
Copy link
Contributor Author

Martii commented May 16, 2016

Do we really want it?

If anyone gets into developing/testing openssl and needs a test platform instead of the prebuilt install binaries then yes. This is a minor glitch as most people won't be deleting their openssl with brew and/or ssl linkage but I usually do forward and reverse regression testings just to be sure. I'm still a bit green on current .pro and haven't found a variable that tells me which target definition it's in. That's all I really need to remove the glitch... alternatively I could just not error and go back to warning... but it will compile galore (trying to shorten compile time since that's a major factor in most C++ based binaries... contributors may get frustrated and move elsewhere if it takes too long to diagnose.). If this was a plain Makefile I would modify to have only the first target definitions run this e.g. make and make all... anything else would skip the test. Qt is a bit peculiar that it creates clean and distclean although it's nice that it does this... just need to determine which "mode" it's in... it's probably a simple one liner too but it's evading my searches... not to mention I need sleep as usual. ;) :)


Some of QupZilla's https errors could possibly be attributed to a ssl bug ... so a good way to test is allow the dev side of openssl.

…ence

* Qt 5.6 doesn't appear to support any other scopes other than `debug` and `release`
* Nothing I could find in `.../mkspecs` that was applicable
* Predefined targets don't seem to have a `build` or `clean` phase state
* Qt `system` calls don't appear to have access to `MAKECMDGOALS`
* Qt `QMAKE_EXTRA_TARGETS` could possibly work if the environment scope was the same... see prior list item

So basically at this time it is an unsupported feature in current Qt... so get to wait until something else pops up or newer functionality.

It is still a good idea to allow dev testing with openssl under Mac ... otherwise it's saying Linux and Windows can test `master` on openssl but Mac users can't.
@Martii
Copy link
Contributor Author

Martii commented May 17, 2016

I'd have to modify/contribute to Qt directly in order to get some scopes in here that would allow termination of the build process (e.g. mac:build vs mac:clean)... so just flipped it to warning.


P.S. Travis does build... seems their test system is busted at the moment...

The command "if [[ "$QT" == "qt56" ]]; then sudo apt-add-repository -y ppa:beineri/opt-qt56-trusty; sudo apt-get update -qq; sudo apt-get install -qq qt56tools qt56script qt56webengine qt56webchannel qt56declarative qt56x11extras; fi" failed and exited with 100 during .

... wasn't busted yesterday and it was passing. Builds fine here on mac dev station.


Opted for existing inconvenience of breaking out of it or having it fail on compile.... instead of breaking make clean and make distclean without reinstalling openssl from pro or dev if manually deleted/uninstalled after a first build.

@Martii
Copy link
Contributor Author

Martii commented May 2, 2017

$ brew upgrade openssl
...
Error: openssl 1.0.2k already installed

Ref:

@Martii
Copy link
Contributor Author

Martii commented Jul 18, 2017

Closing from lack of interest.

@Martii Martii closed this Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants