Feature ananlysis jobs items integration #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analysis Jobs' models and controllers were previously setup. This commit introduces changes that make the jobs workflow functionally complete. Also included is a comprehensive suite of API level specs that simulate and tests many full-lifecycle scenarios of the analysis jobs system. This is a combination of 14 commits that were squashed when cleaning up this work. - Integration test defintions for AnalysisJobs/Items - Started implementing tests - Implementation work - Got :new integration tests working - Made a fake resque job - Made job notification emails - Fixed faulty update_status_timestamps method and fixed associated tests - Hardened state transition test for AnalysisJobsItem - more work on processing stage - almost got prepare working - Begun adding aasm workflow to analysis_jobs_items - Got most of processing tests working - Added extra scripts field to support arbitrary options for analysis_action - Work on processing analysis_jobs_items - Fixed strong params definition for both AnalysisJobs and AnalysisJobsItems - 75% of unit tests complete - Added timecop for micking time in tests (later removed this gem as well - it wasn't needed) - All creating an analysis job request specs now work! 馃帀 - Added support for deleting analysis jobs. Analysis jobs can only be deleted when their status is processing, suspended, or completed. - Also added tests for AnalysisJobs and AnalysisJobsItems
Changed strong params from :log to :raise for DEV and TEST environments in a previous commit. Now fixed up the related tests.
The mege conflict in ef0155e was massive. For clarity split commit into two parts, the basic merge conflict, and then the bugs that it produced (only exposed when running tests). - WARNING: Strong params now throws an exception for all parameter payloads in dev an test. However, payloads with invalid params will simply be filtered out in staging and production environments. - Fixed bug in `rails_helper.rb` which did not reseed the database after truncating it in request specs - Updated version of acts_as_paranoid no longer adds unecessary parentheses - fixed hard coded SQL tests - Made the `permissions_controller.rb` tests more robust to strong params hardening. They will now work even when `action_on_unpermitted_parameters` is set to `:raise`
|
I've run these tests on two separate machines and they passed. The CI tests failed because of an incorrect postgres version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Analysis Jobs iintegration complete.
Analysis Jobs' models and controllers were previously setup.
This commit introduces changes that make the jobs workflow
functionally complete.
Closes #192. Closes #193. Closes #200.
Also included is a comprehensive suite of API level specs that
simulate and tests many full-lifecycle scenarios of the analysis
jobs system.
This is a combination of 14 commits that were squashed when
cleaning up this work.