Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ananlysis jobs items integration #300

Merged
merged 7 commits into from
Aug 5, 2016

Commits on Jul 31, 2016

  1. Feature: Analysis Jobsintegration complete.

    Analysis Jobs' models and controllers were previously setup.
    This commit introduces changes that make the jobs workflow
    functionally complete.
    
    Also included is a comprehensive suite of API level specs that
    simulate and tests many full-lifecycle scenarios of the analysis
    jobs system.
    
    This is a combination of 14 commits that were squashed when
    cleaning up this work.
    
    - Integration test defintions for AnalysisJobs/Items
    - Started implementing tests
    - Implementation work
    - Got :new integration tests working
    - Made a fake resque job
    - Made job notification emails
    - Fixed faulty update_status_timestamps method and fixed associated tests
    - Hardened state transition test for AnalysisJobsItem
    - more work on processing stage
    - almost got prepare  working
    - Begun adding aasm workflow to analysis_jobs_items
    - Got most of processing tests working
    - Added extra scripts field to support arbitrary options for analysis_action
    - Work on processing analysis_jobs_items
    - Fixed strong params definition for both AnalysisJobs and AnalysisJobsItems
    - 75% of unit tests complete
    - Added timecop for micking time in tests (later removed this gem as well - it wasn't needed)
    - All creating an analysis job request specs now work! 馃帀
    - Added support for deleting analysis jobs. Analysis jobs can only be deleted when their status is processing, suspended, or completed.
    - Also added tests for AnalysisJobs and AnalysisJobsItems
    atruskie committed Jul 31, 2016
    Configuration menu
    Copy the full SHA
    f209c5a View commit details
    Browse the repository at this point in the history
  2. Updated acts_as_paranoid gem

    atruskie committed Jul 31, 2016
    Configuration menu
    Copy the full SHA
    288878b View commit details
    Browse the repository at this point in the history
  3. Fixed unit tests. Bugs related to strong params.

    Changed strong params from :log to :raise for DEV and TEST environments
    in a previous commit. Now fixed up the related tests.
    atruskie committed Jul 31, 2016
    Configuration menu
    Copy the full SHA
    c1cd2b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2016

  1. Configuration menu
    Copy the full SHA
    04bac09 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2016

  1. Resolved merge conflicts

    atruskie committed Aug 4, 2016
    Configuration menu
    Copy the full SHA
    ef0155e View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2016

  1. Fixed bugs introduced by merge conflict

    The mege conflict in ef0155e was
    massive. For clarity split commit into two parts, the basic merge
    conflict, and then the bugs that it produced (only exposed when running
    tests).
    
    - WARNING: Strong params now throws an exception for all parameter
    payloads in dev an test. However, payloads with invalid params will
    simply be filtered out in staging and production environments.
    - Fixed bug in `rails_helper.rb` which did not reseed the database after
    truncating it in request specs
    - Updated version of acts_as_paranoid no longer adds unecessary
    parentheses - fixed hard coded SQL tests
    - Made the `permissions_controller.rb` tests more robust to strong
    params hardening. They will now work even when
    `action_on_unpermitted_parameters` is set to `:raise`
    atruskie committed Aug 5, 2016
    Configuration menu
    Copy the full SHA
    6791dad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e80ee2 View commit details
    Browse the repository at this point in the history