-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades to Rails 6 #470
Upgrades to Rails 6 #470
Commits on Jun 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e345d8a - Browse repository at this point
Copy the full SHA e345d8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 198560c - Browse repository at this point
Copy the full SHA 198560cView commit details
Commits on Jun 8, 2020
-
Revent version bump means new rules were added and some old rules were removed
Configuration menu - View commit details
-
Copy full SHA for 04d489d - Browse repository at this point
Copy the full SHA 04d489dView commit details -
Folds in resque-status gem because source code base is unmaintained. Adds sprockets manifest file. Enables reloading for web app if running development server.
Configuration menu - View commit details
-
Copy full SHA for 5c9aa3b - Browse repository at this point
Copy the full SHA 5c9aa3bView commit details -
Changes made according to https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-2-to-rails-5-0
Configuration menu - View commit details
-
Copy full SHA for 27c8352 - Browse repository at this point
Copy the full SHA 27c8352View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1ea043 - Browse repository at this point
Copy the full SHA f1ea043View commit details
Commits on Jun 12, 2020
-
- move all autoload code into app where rails will be able to load it without issue or configuration - move gem folders into proper gem structures - cleaned up application.rb - moving more things to initializers makes it much clearer what is going on - started to deprecate settings logic (which is unmaintained) - removed trim from nameywamey - it's better suited as a patch that everything can use
Configuration menu - View commit details
-
Copy full SHA for 522bd8b - Browse repository at this point
Copy the full SHA 522bd8bView commit details
Commits on Jun 17, 2020
-
SettingsLogic is no longer maintained, so I've switched to rubyconfig/config. Also cleared out as many warnings as I could during app boot. This means that autoloading constants is no longer allowed in initializers. Changes were made to including AlphabeticalPaginatorQuery and the i8ln-inflector railtie (see new patch). WIP: tests still need to be run
Configuration menu - View commit details
-
Copy full SHA for 01eb988 - Browse repository at this point
Copy the full SHA 01eb988View commit details
Commits on Jun 18, 2020
-
Ensures application can be eager loaded
Tested with rails zeitwerk:check
Configuration menu - View commit details
-
Copy full SHA for 499e268 - Browse repository at this point
Copy the full SHA 499e268View commit details -
Update factory girl to facotory bot
Also added support for use database_cleaner on redis
Configuration menu - View commit details
-
Copy full SHA for ca4d823 - Browse repository at this point
Copy the full SHA ca4d823View commit details
Commits on Jun 19, 2020
-
Update specs to handle new framework defaults
Main thing is that belongs_to associations are now required by default. Also removed old validators.
Configuration menu - View commit details
-
Copy full SHA for a67e48d - Browse repository at this point
Copy the full SHA a67e48dView commit details
Commits on Jun 22, 2020
-
Mainly involved adding :optional to associations that were optional (since associations are now required by default in rail 6+) Also had to override more of the big decimal json serialization so it would actually take effect when serializing notes to the database. Defined helper methods to refer to the default dataset as well and ensured the helpers were used in the seeds and tests. -> { uniq} is deprecated and needed to be replaces with distinct. the activesupport parameterize method requires named arguments to work now.
Configuration menu - View commit details
-
Copy full SHA for 2af38a6 - Browse repository at this point
Copy the full SHA 2af38a6View commit details
Commits on Jun 25, 2020
-
Fix saved search tests, upgrade stored_query to JSON
Partially adresses #467. The now deprecated `serialize` constrtuct that used to be applied to models that store hashes in a text field is *now* taken into account when AREL constructs queries. The result was a double-encoded JSON string used a value to search for in the database which would obviously never match anything! Made the following changes to adress this: - simplified strong params - migrated stored_query to jsonb - allowed our API code to accept a Hash as a primitive value to compare against in queries, IFF the type of the column of the attribute is JSON. - and adjusted the acceptance test so that a true hash is passed rather than a JSON encoded string Also added patches to AREL for retrieving the type of an attribute. Also canonicalised our is_json postgres function.
Configuration menu - View commit details
-
Copy full SHA for 5aa9bff - Browse repository at this point
Copy the full SHA 5aa9bffView commit details
Commits on Jun 28, 2020
-
After the rails 6 upgrade the container no longer booted correctly. - bumped our bundler version - attempted to run uby 2.7 but our dependecies do not allow it (nokogiri being the main offender) - Ensured database configuration works in multi-database mode. By default db: commands now operate on development and test environments at the same time (a rails default). - simplified the app boot experience by: - wholly incorporating the migrate experience into the rake task - which removed the need for two bash files migrate.sh and dev_setup.sh (along with multi-database feature) - fixed an issue where local gems were not avaiable for bundle install because they were not yet copied to the container - fixed an issue where workers would not boot because dry-validation was not loaded - moved the cors code to an initializer file
Configuration menu - View commit details
-
Copy full SHA for a02c880 - Browse repository at this point
Copy the full SHA a02c880View commit details
Commits on Jun 29, 2020
-
Now ensures workers cannot access postgres db by placing them on serparate networks. Also corrects condition on which datbase migration checks are run. Also wrapped database keys in config in strings - seems to obviate the rails config/erb-simplify warning.
Configuration menu - View commit details
-
Copy full SHA for 7c5bf08 - Browse repository at this point
Copy the full SHA 7c5bf08View commit details
Commits on Jun 30, 2020
-
The .from method was changed in rails/arel@98fc259 Fixes the method and relvant tests (along with formatting). Fixes: ArgumentError: wrong number of arguments (given 1, expected 0) # /usr/local/bundle/gems/activerecord-6.0.3.2/lib/arel/table.rb:33:in `from'
Configuration menu - View commit details
-
Copy full SHA for 7d0b90b - Browse repository at this point
Copy the full SHA 7d0b90bView commit details
Commits on Jul 1, 2020
-
- mainly strong params fixes - strong params is no longer a hash so also a fair few calls to to_h were added to coerce params into a hash that the rest of our lib could deal with it - was also able to simplify some hash params filtering (re #467 ) - fixed error handling due to error being moved from env to request.env for uncaught error - adds support for type casting columns in arel - that is used to allow us to use `contains` filters on json columns (subet.rb)
Configuration menu - View commit details
-
Copy full SHA for 3e501c4 - Browse repository at this point
Copy the full SHA 3e501c4View commit details -
Allows variably defined deps for docker build
File should have been committed with a02c880
Configuration menu - View commit details
-
Copy full SHA for 88b58e2 - Browse repository at this point
Copy the full SHA 88b58e2View commit details
Commits on Jul 2, 2020
-
Enforce parentheses in condition for project permission
Something changed somewhere that changed wether or not AREL outputs parentheses around an expression. In this case the change was sginficant because the RHS of the permissions expression short-circuited the rest of the predicates Used a Arel::Nodes::Grouping to enforce parantheses output.
Configuration menu - View commit details
-
Copy full SHA for 719c7e8 - Browse repository at this point
Copy the full SHA 719c7e8View commit details
Commits on Jul 6, 2020
-
Finished test fixes for rails 6 upgrade
- completely removed BawWorkers::Settings alias. It introduced subtle bugs for the sake of avoiding a mass change - the mass change ended up being easier - removed use_ssl as an option for worker API access. We're pretty reliant on https now so there's no use having an option that disables ssl - conveted workers mailer to use erb views - ended up being simpler than rendering inline content since rails requires views must exist regardless
Configuration menu - View commit details
-
Copy full SHA for 427e556 - Browse repository at this point
Copy the full SHA 427e556View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4882635 - Browse repository at this point
Copy the full SHA 4882635View commit details
Commits on Jul 8, 2020
-
Merge master, fix hash processing
The method used to sanitize hashes recieved by the API was no longer viable in Rails 6. I had to adapt the method and in doing so I also wrote more tests. Additionally, the factory bot code somehow imported the database status rake task and was using methods from that file when constructing factories. Not only should this be impossible but it is also very bad. I renamed the methods in the rake file so at a minimum they could not be mistakenly referenced (due to sharing common identifiers ). Root cause unknown.
Configuration menu - View commit details
-
Copy full SHA for bfe02ae - Browse repository at this point
Copy the full SHA bfe02aeView commit details -
It was using hard coded unique ids that failed due to a primary key conflict. Replaced with a dyanmic expression.
Configuration menu - View commit details
-
Copy full SHA for 9891e5b - Browse repository at this point
Copy the full SHA 9891e5bView commit details