This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
extend the list of categories #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-dupre
force-pushed
the
classif-category-extend
branch
from
8ebe024
to
029575f
Compare
remi-dupre
force-pushed
the
classif-category-extend
branch
from
029575f
to
8b60523
Compare
remi-dupre
changed the title
amatissart
reviewed
Apr 12, 2021
remi-dupre
force-pushed
the
classif-category-extend
branch
from
cc867ed
to
1b7d030
Compare
amatissart
reviewed
Apr 22, 2021
idunn/utils/categories.yml
Outdated
| raw_filters: | ||
| - "railway,station" | ||
| - "railway,halt" | ||
| pj_what: "gare" |
There was a problem hiding this comment.
Sorry for the oversight, I think that this pj_what should be removed here too. It was not present before.
Maybe false positives are returned by PJ for such a query.
Apart from that, everything looks good to me 👍
There was a problem hiding this comment.
That's fixed, sorry about this, my approach to this PR was absolutely messy and counter-productive ... I'm sorry about the time it must have taken to review and quite relieved it comes to an end :|
remi-dupre
force-pushed
the
classif-category-extend
branch
from
1b7d030
to
1f71ebf
Compare
amatissart
approved these changes
Apr 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the list of categories to match what the classifier can identify.
Some updates to karthoterian_docker (WIP) are required to cover all the POIs and categories, especially:
cuisinetag prior toleisurein order to setclass,subclass=restaurant,cuisine_type.