This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
pj_poi: add conversion to class for all categories supported by #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-dupre
force-pushed
the
pj-category-filters
branch
from
1285946
to
cb27f36
Compare
bbecquet
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All categories results from pagesjaunes should now have a specified class, this allows erdapfel to identify what to display as a category.
There may still be some POIs for which we display no categories, especially when performing a full-text search which is triggered when the tagger detects a brand intention).
Note that all the added classes are already recognized by erdapfel (even though I managed to break that while I was investigating on how erdapfel delt with this ... 🙄).