This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Add migration for new release #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the old version of masq alpha, the device entry in the profile
db did not contain the apps info after an activation with maps.
We therefore add :
- _checkversion during openProfile
- _addVersion for addProfile
- _migration in case we need it
G-Ray
reviewed
Oct 17, 2019
src/lib/masq.js
Outdated
| debug(`The version ${process.env.REACT_APP_VERSION} has been added.`) | ||
| } | ||
|
|
||
| async _migration (profileId) { |
There was a problem hiding this comment.
ok, can you move this to a migrations/v0.16.js file ?
G-Ray
reviewed
Oct 17, 2019
src/lib/migrations/v0.16.js
Outdated
| const migration = async (masq, profileId) => { | ||
| debug('start migration') | ||
| const device = await masq.getDevice() | ||
| if (!device) { |
There was a problem hiding this comment.
this is systematically done in openProfile() I think ?
There was a problem hiding this comment.
Line 197 in 407fc17
G-Ray
reviewed
Oct 17, 2019
| const appDb = masq.appsDBs[appId] ? masq.appsDBs[appId] : openOrCreateDB(appId) | ||
| await masq.updateDevice({ | ||
| ...myDevice, | ||
| apps: [...myDevice.apps, { |
G-Ray
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.