fix(generic): coerce undefined data into null
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around an IE bug exposed on DELETE requests.
Qwerios
added a commit
that referenced
this pull request
Jun 26, 2015
fix(generic): coerce undefined `data` into `null`
|
Not using a lot of IE10 here so would not have caught that. Thanks |
|
Published version 0.1.20 to npmjs with this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an IE10 bug exposed on DELETE requests, that would otherwise include a
Content-length: 9header ("undefined".length === 9) but no body content on the request.On a keep-alive connection this is sure to break any immediately following request.
The issue is also found and discussed in angular/angular.js#12141