Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insights typo in tailwind #6351

Closed
seanperez-xyz opened this issue May 21, 2024 · 5 comments · Fixed by #6358
Closed

insights typo in tailwind #6351

seanperez-xyz opened this issue May 21, 2024 · 5 comments · Fixed by #6358
Assignees

Comments

@seanperez-xyz
Copy link

this has been like this for months...
since it hasn't been fixed I assume it doesn't affect anything but...
I copy paste this alot 😭
pretty sure its
overflow
not
verflow

class="verflow-hidden rounded-full border border-slate-300 leading-[0px]"

@seanperez-xyz
Copy link
Author

seanperez-xyz commented May 21, 2024

I guess if you wanted to implment the sizes it would be something mundane like


enum AvatarSize {
    xs = 24,
    sm = 32,
    md = 40,
    lg = 80,
    xl = 144,
}
export interface AvatarProps {
    src: string;
    alt: string;
    size?: keyof typeof AvatarSize
}
export default component$<AvatarProps>(({
    size = 'md',
    ...props
}) => {

    return (
        <img
            src={props.src}
            alt={props.alt}
            class={
                cn("overflow-hidden rounded-full border border-slate-300 leading-[0px]"
                )
            }
            width={AvatarSize[size]}
            height={AvatarSize[size]}
        />
    );
});

( not going to clone the whole thing to make a pull request)

@PatrickJS
Copy link
Member

Can you make a pr

@JerryWu1234
Copy link
Contributor

let me try

@JerryWu1234
Copy link
Contributor

done this @PatrickJS

@gioboa gioboa linked a pull request May 22, 2024 that will close this issue
7 tasks
@gioboa
Copy link
Member

gioboa commented May 22, 2024

Thanks @JerryWu1234 for your great help 👏

@gioboa gioboa closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants