Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssr aws lambda apdapter #1784

Closed
wants to merge 1,377 commits into from
Closed

Conversation

leifermendez
Copy link
Contributor

What is it?

New Adaptor for AWS Lamda
https://share.vidyard.com/watch/yKuXu8uiPpgRqHopySs9Pe?
image

  • [x ] Feature / enhancement
  • Bug
  • Docs / tests

Description

New implementation for deploy qwik add easy

Example: https://rsltkw254b.execute-api.us-east-1.amazonaws.com/

Checklist:

  • [ x] My code follows the developer guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have made corresponding changes to the documentation
  • [x ] Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Oct 18, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@leifermendez
Copy link
Contributor Author

leifermendez commented Oct 18, 2022

If somebody wanna check the serverless-plugin-qwik 😉 PR welcome
serverles

@adamdbradley
Copy link
Contributor

We just made an update to how servers/adaptors are imported from Qwik City projects. Would you be able to update this PR to the last structure updates? https://github.com/BuilderIO/qwik/tree/cdea8ff43b2f7f3eab1634c795e360c8a5ae7ec9/starters/adaptors/cloudflare-pages

This will be a great addition, thanks!

@leifermendez
Copy link
Contributor Author

New structure applied @adamdbradley also i removed somes dependencies and moved a logic part to other package for avoid mix stranger somethings here.

https://github.com/leifermendez/serverless-plugin-qwik

@leifermendez leifermendez marked this pull request as draft October 22, 2022 11:55
@leifermendez
Copy link
Contributor Author

I need to review some files and make a test @adamdbradley I hope the next week launch an update

@zanettin
Copy link
Collaborator

Hi @leifermendez 👋
Just scanning the open PRs and found this one 😄 a bit dusty but looks as good as new 🤣 what's the state of it?

@zanettin zanettin changed the title ssr aws lambda apdapter feat: ssr aws lambda apdapter Feb 25, 2023
@leifermendez
Copy link
Contributor Author

Hi @leifermendez 👋 Just scanning the open PRs and found this one 😄 a bit dusty but looks as good as new 🤣 what's the state of it?

🙌 Hi @zanettin I need check this again because I remember this I left as draft for something but I not exactly the cause

manucorporat and others added 25 commits May 26, 2023 18:29
* Add BuiltWithAppwrite to pages.json

* prettier

---------

Co-authored-by: Roman Zanettin <roman.zanettin@gmail.com>
* 🥝

* docs: add new course in arabig (QwikDev#4281)

* Added a new resource to the course section

* commit after running pnpm fmt

* prettier

---------

Co-authored-by: Roman Zanettin <roman.zanettin@gmail.com>

* docs: add udemy courses from manuelsanchez (QwikDev#4233)

* Add two more courses

* Update index.tsx

---------

Co-authored-by: roman zanettin <zanettin@users.noreply.github.com>

---------

Co-authored-by: AL-Hareth <alharethturab@gmail.com>
Co-authored-by: Manuel Sanchez <68222396+manuelsanchez2@users.noreply.github.com>
* Import naming fixing index.mdx

Deprecated full capitalized import

* adjusted code highlighting

* Update index.tsx

---------

Co-authored-by: roman zanettin <zanettin@users.noreply.github.com>
Add RadixStream which is a subscription site built with Qwik.
…v#4357)

* docs: ✏️ Add documentation and example for QwikIntrinsicElements

✅ Closes: QwikDev#4148

* Generate API and format code

* Update example code

To be an instantly working one
- Simplify the streaming code
 - Fix a bug that could lead to ERR_STREAM_DESTROYED
 - Implement proper async generator cleanup
 - Add some documentation
… into ssr/lambda-fix"

This reverts commit 8a7e210, reversing
changes made to 6f74561.
if (callout) {
classes.push('callout-anchor');
}
HTML.push(`<span class="${classes.join(' ')}">${token.text.replace('<', '&lt;')}</span>`);

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '<'.
</li>
</ul>
<div class="url bg-slate-300 rounded-md inline-grid whitespace-nowrap text-xs px-2 py-1 content-center w-full">
<a

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@leifermendez
Copy link
Contributor Author

Close! continue here because here I don't know what happend ... #4390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet