Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showcase: Add Qwind starter template #2343

Merged
merged 4 commits into from
Dec 3, 2022
Merged

showcase: Add Qwind starter template #2343

merged 4 commits into from
Dec 3, 2022

Conversation

prototypa
Copy link
Contributor

@prototypa prototypa commented Dec 2, 2022 •
edited

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Addition of the Qwind starter template to the Qwik Showcase. Qwind is a ready template for creating a website with Qwik and Tailwind CSS. As a philosophy it tries to be simple, follow good practices and high performance.

Use cases and why

  • A new website will appear in the Qwik showcase

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Dec 2, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manucorporat
Copy link
Contributor

This is amazing! the burger button is mobile is not working, could check what's up?

manucorporat
manucorporat reviewed Dec 2, 2022
View reviewed changes
packages/docs/scripts/pages.json Outdated
},
{
"href": "https://qwind.pages.dev/",
"tags": "template"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"tags": "template"
"tags": "template",
"repo": "ADD LINK TO REPO",

@prototypa
Copy link
Contributor Author

prototypa commented Dec 2, 2022 •
edited

@manucorporat

This is amazing! the burger button is mobile is not working, could check what's up?

I'll check it right now and let you know, thank you very much

@prototypa
Copy link
Contributor Author

@manucorporat

Now the burger button in mobile is working! Thanks

@prototypa
Copy link
Contributor Author

@manucorporat

And I'm sorry, I didn't understand the suggestion in the pages.json file until now.
I have now added the template repository as you suggested.

{
    "href": "https://qwind.pages.dev/",
    "tags": "template",
    "repo": "https://github.com/onwidget/qwind"
}

@manucorporat
Copy link
Contributor

Amazing! yeah the repo thing is not being used yet, but we plan to include a button to tht source code soon!

@manucorporat
Copy link
Contributor

you need to remove the last comma in the JSON, trailing commas are not valid in JSON

@prototypa
Copy link
Contributor Author

you need to remove the last comma in the JSON, trailing commas are not valid in JSON

@manucorporat
Yes yes, the truth is that I have caused chaos in a little piece of PR. I woke up after having slept very badly and with the emotion that you were going to approve my PR I have done very strange things.

I have already removed the comma at the end. Really sorry.

@manucorporat
Copy link
Contributor

no worries!! this is amazing my friend! i will merge as soon as the CI passes!

@manucorporat manucorporat merged commit b3c50aa into QwikDev:main Dec 3, 2022
reemardelarosa pushed a commit to reemardelarosa/qwik that referenced this pull request Dec 8, 2022
@prototypa @reemardelarosa
docs: Add Qwind starter template to showcase (QwikDev#2343)
8f95e4b
mhevery pushed a commit that referenced this pull request Dec 22, 2022
@reemardelarosa @manucorporat
@adamdbradley @ssmlee04 @TejasQ @bryanhannes @jwickers @forresst @Mhmdrza @shairez @brunocrosier @almilo @utherpally @Wimpert @prototypa @nnelgxorz @wmertens @saikatdas0790 @the-r3aper7 @Kesmek @zanettin @jweb89 @tuoitrevohoc @machineloop
docs: added cheatsheet for best practices (#2266)
eec2096 
* docs: added cheatsheet for anti patterns

* docs:cleanup

* chore: another clickup and spacing update

* chore: Release 0.14.1 (#2264)

* 0.14.1

* 🐤

* fix: page, endpoint, q-data GET request (#2265)

* chore: release qwik-city 0.0.127 (#2269)

* chore: Add my stock investing website (#2268)

:)

* fix: signal rendering of classes (#2271)

fixes #2245

* docs: fix a typo (#2279)

* docs: Inline causes the clock to not show (#2283)

clock.css is not correctly loaded which causes the clock to not show.
Error: Cannot find module './clock.css?inline' or its corresponding type declarations.

* docs: Tutorial onError should be onRejected (#2284)

When using onError in the IDE as provided in the example it gives the following error:
Property 'onError' does not exist on type 'IntrinsicAttributes & ResourceProps<string[]>'

The solution says it should be onRejected

* fix: not silent error during rendering (#2297)

* fix: correctly handle draggable and spellcheck (#2299)

Co-authored-by: Jeremy Wickersheimer <jwickers@gmail.com>

* docs: right menu for Getting Started & Think Qwik (#2243)

* fix: dev server 302 error (#2300)

* feat: non-serializable response data dev error (#2305)

* docs: fix typo (#2302)

* docs: include vercel edge in the adaptors overview (#2292)

* fix(optimizer): missing args passed to wasm fallback (#2308)

* fix: textarea value rendering in SSR (#2309)

fixes #2235

* feat: better error reporting (#2312)

* fix: render toggle + signal (#2313)

fixes #2311

* feat: Link prefetch by default (#2314)

* fix: useContent menu lookup (#2315)

* docs: updated img-models url in showcase (#2320)

* fix: rendering of sibling component and mandatory key (#2321)

* feat: click-to-source  (#2217) (#2319)



Co-authored-by: Bruno Crosier <bruno.crosier@gmail.com>

* chore: 0.15.0 (#2330)

* fix: client redirect for trailing slash (#2333)

* fix: forceConsistentCasingInFileNames in starters (#2334)

* docs: fix typos and improve explanations (#2332)

* fix: click-to-component (#2335)

* docs: fix some typos and align explanations (#2331)

* release: qwik-city 0.0.128 (#2337)

* docs: fix build.preview (#2341)

* chore: add vite ecosystem scripts (#2349)

* docs: fix typo lifecycle (#2346)

* feat: add URLSearchParams to serializer (#2352)

* refactor: use class prop without casting to any (#2348)


Co-authored-by: langbamit <langbamit@gmail.com>

* feat: add to package.json when present in the ssr dir (#2354)

* docs: Add Qwind starter template to showcase (#2343)

* fix: detect and error on array holes (#2356)

* chore: remove className (#2310)

* fix: textarea vdom patching (#2357)

fixes #2344

* fix: update features (#2363)

* fix: jsx rule with fragment (#2364)

fixes #2177

* feat: Pre-fetch Link data on anchor focus (#2358)

* fix: useClientEffect() in empty components (#2365)

fixes #1955
fixes #2329
fixes #1062
fixes #1413
fixes #1446

* chore: release 0.15.1 (#2366)

* docs: improve styling docs (#2367)

* fix: make array hole test more readable (#2369)

* 0.15.2 (#2371)

* docs: fix typo (#2372)

* docs: removed unnecessary fragments (#2361)

* docs: Add Guide On Using Map Functions In JSX (#2373)

* docs: remove async from component$ overview (#2377)

* feat: add config for dev inspector (#2375)

* docs(qwik-v-react): fix array key consistency in docs (#2383)

Qwik array map in qwik vs. react did not have key even though in rendering portion of docs it says
key is required

* fix(vite): module side effect (#2387)

* feat: detect invalid HTML (#2389)

* docs: link accessibility (#2386)

* feat: standardize params/query api (#2385)

Co-Authored-By: Tran Thien Khiem <20198928+tuoitrevohoc@users.noreply.github.com>

* docs(contributing): Add install note for wasm-pack (#2390)

To avoid running into unexpected `wasm-pack` failures when doing full build, adds note to Contributing docs about installation of `wasm-pack`, linking to site showing installation command for each platform.

* docs: update anti pattern to best practice

Co-authored-by: Manu MA <manu.mtza@gmail.com>
Co-authored-by: Adam Bradley <adamdbradley@users.noreply.github.com>
Co-authored-by: Shih-Min Lee <ssmlee04@gmail.com>
Co-authored-by: Tejas Kumar <tejas+lol@tejas.qa>
Co-authored-by: Bryan Hannes <31400961+bryanhannes@users.noreply.github.com>
Co-authored-by: Jeremy Wickersheimer <jwickers@gmail.com>
Co-authored-by: Forresst <forresst17@gmail.com>
Co-authored-by: Mhmdrz_a <mr.ala72@gmail.com>
Co-authored-by: Shai Reznik <shairez@users.noreply.github.com>
Co-authored-by: Bruno Crosier <bruno.crosier@gmail.com>
Co-authored-by: Alberto Mijares <almilo@users.noreply.github.com>
Co-authored-by: Uther Pally <43192714+langbamit@users.noreply.github.com>
Co-authored-by: langbamit <langbamit@gmail.com>
Co-authored-by: Wim Holvoet <holvoetwim@gmail.com>
Co-authored-by: prototypa <54446028+prototypa@users.noreply.github.com>
Co-authored-by: Glenn Becker <nnelgxorz@gmail.com>
Co-authored-by: Wout Mertens <Wout.Mertens@gmail.com>
Co-authored-by: Saikat Das <saikatdas0790@gmail.com>
Co-authored-by: Sai Srikar Dumpeti <80447788+the-r3aper7@users.noreply.github.com>
Co-authored-by: Justin Scopelleti <38704268+Kesmek@users.noreply.github.com>
Co-authored-by: roman zanettin <zanettin@users.noreply.github.com>
Co-authored-by: jweb89 <62513031+jweb89@users.noreply.github.com>
Co-authored-by: Tran Thien Khiem <20198928+tuoitrevohoc@users.noreply.github.com>
Co-authored-by: machineloop <3682072+machineloop@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manucorporat manucorporat manucorporat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prototypa @manucorporat