Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudflare): wait to cache until response complete #3679

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix(cloudflare): wait to cache until response complete #3679

merged 3 commits into from
Mar 4, 2024

Conversation

manucorporat
Copy link
Contributor

No description provided.

@stackblitz
Copy link

stackblitz bot commented Apr 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 5, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b74447
Status: ✅  Deploy successful!
Preview URL: https://0dd5b392.qwik-docs.pages.dev
Branch Preview URL: https://wait-until-cloudflate.qwik-docs.pages.dev

View logs

@manucorporat manucorporat mentioned this pull request Apr 6, 2023
Closed
@zanettin
Copy link
Contributor

still smth we should merge @manucorporat ? 👼

@zanettin zanettin added WAITING FOR: user Further information is requested from the issue / pr opener COMP: starters labels Aug 26, 2023
@gioboa gioboa marked this pull request as draft January 8, 2024 20:43
@wmertens wmertens marked this pull request as ready for review March 4, 2024 09:15
@netlify Netlify
Copy link

netlify bot commented Mar 4, 2024 •
edited
Loading

✅ Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 0b74447
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/65e5941309cb200008f7b8eb
😎 Deploy Preview https://deploy-preview-3679--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wmertens wmertens changed the title fix: wait until for cloudflare fix(cloudflare): wait to cache until response complete Mar 4, 2024
@wmertens wmertens enabled auto-merge (squash) March 4, 2024 09:29
@wmertens wmertens merged commit 1995753 into main Mar 4, 2024
29 checks passed
@wmertens wmertens deleted the wait-until-cloudflate branch March 4, 2024 09:44
wmertens added a commit to wmertens/qwik that referenced this pull request Mar 5, 2024
@wmertens
Revert "fix(cloudflare): wait to cache until response complete (QwikD…
9235994 
…ev#3679)"

This reverts commit 1995753.

Somehow, this causes the server to not send out correct Cache headers
wmertens added a commit that referenced this pull request Mar 5, 2024
@wmertens
Revert "fix(cloudflare): wait to cache until response complete (#3679)…
6f2e515 
…" (#5952)

This reverts commit 1995753.

Somehow, this causes the server to not send out correct Cache headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees
No one assigned
Labels
COMP: starters WAITING FOR: user Further information is requested from the issue / pr opener
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manucorporat @zanettin @wmertens