Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): generate correct routes.gen.d.ts for dynamic segments #5866

Merged

Conversation

blueagler
Copy link
Contributor

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Fix the problem when using Dynamic route segments, qwik-types cannot generate correct routes.gen.d.ts
CleanShot 2024-02-20 at 16 52 03@2x
CleanShot 2024-02-20 at 16 49 23@2x

Test Passed:
CleanShot 2024-02-20 at 16 59 24@2x

Use cases and why

    1. part.startsWith('[') will not intersect with part.startsWith('...')

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Feb 20, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 18c579c

@blueagler blueagler changed the title Fix the problem when using Dynamic route segments, qwik-types cannot generate correct routes.gen.d.ts fix: Fix the problem when using Dynamic route segments, qwik-types cannot generate correct routes.gen.d.ts Feb 20, 2024
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wmertens wmertens changed the title fix: Fix the problem when using Dynamic route segments, qwik-types cannot generate correct routes.gen.d.ts fix(routing): generate correct routes.gen.d.ts for dynamic segments Feb 22, 2024
@wmertens wmertens merged commit a03a2f9 into QwikDev:main Feb 22, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants