fix: read q:base to get the script path for the shim #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
mhevery
requested changes
Feb 20, 2024
jcfauchet
force-pushed
the
fix/spa-shim-script
branch
from
3da15b1
to
79f5625
Compare
mhevery
approved these changes
Feb 20, 2024
mhevery
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The initial issue revolves around the SPA Shim Script, which fails to utilize the correct base for loading the JavaScript script when a custom base is configured in
entry.ssr.ts.After discussing with Miško, he guided me on how to make the script read the path from the
q:baseattribute, mirroring its behavior in dev mode.What is it?
Description
The approach is to get the base path from the q:base attribute as it's done in dev mode
Checklist: