Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): manage workspace protocol #5871

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix(build): manage workspace protocol #5871

merged 2 commits into from
Feb 21, 2024

Conversation

wmertens
Copy link
Member

This fixes the artifact builds so they don't have workspace:* as their version and it also replaces workspace package versions with workspace:^ after pnpm deps.

Both are managed thanks to syncpack.

Also make workspace deps be `^` so that e.g. qwik-react doesn't fail
on newer qwik versions
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit c11736b
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/65d5ef05dcacba0008989b46
😎 Deploy Preview https://deploy-preview-5871--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-pages bot commented Feb 21, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c11736b
Status: ✅  Deploy successful!
Preview URL: https://e08535f5.qwik-docs.pages.dev
Branch Preview URL: https://build-fix-builds.qwik-docs.pages.dev

View logs

@wmertens wmertens merged commit 3f9e486 into main Feb 21, 2024
45 checks passed
@wmertens wmertens deleted the build/fix-builds branch February 21, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant