Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show selected path if block scroll in view #6079

Merged

Conversation

RaiVaibhav
Copy link
Contributor

@RaiVaibhav RaiVaibhav commented Mar 31, 2024

Fixes: #6081
In output section of playground, as per the code-block in view, show the selected path on the left side.

(Also mentioned about this change in discord, kindly close the PR is its not needed)

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Mar 31, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 76f3318

@RaiVaibhav RaiVaibhav marked this pull request as draft March 31, 2024 18:26
@RaiVaibhav RaiVaibhav force-pushed the fix/docs-show-item-in-view-onscroll branch 2 times, most recently from 887ad73 to 6008d06 Compare April 2, 2024 05:58
@RaiVaibhav
Copy link
Contributor Author

  • In output section of playground, as per the code-block in view, show the selected path on the left side i.e., using scroll to view and setting the path as a selected and changing the text color ?
  • In output section of playground, we should have an option to copy the code from the code-block?

These two points are done

@RaiVaibhav
Copy link
Contributor Author

Hey @wmertens, kindly let me know what you think about these changes

Instead of using the drawer I changed the grid layout for mobile devices, I feel this is better?

Recording.2024-04-02.132532.mp4

@RaiVaibhav
Copy link
Contributor Author

RaiVaibhav commented Apr 7, 2024

Hey @wmertens have a look at the comment #6079 (comment) and let me know what you feel about the changes, so that I can proceed towards completing the PR.

@wmertens
Copy link
Member

Looks good!

@RaiVaibhav
Copy link
Contributor Author

Thanks I will start on this again

@PatrickJS
Copy link
Member

once this is update I'll merge it

@PatrickJS PatrickJS force-pushed the fix/docs-show-item-in-view-onscroll branch from f910a83 to 7a83220 Compare May 11, 2024 21:13
@PatrickJS PatrickJS marked this pull request as ready for review May 11, 2024 21:14
@PatrickJS PatrickJS merged commit 80ea7cf into QwikDev:main May 12, 2024
22 checks passed
@PatrickJS
Copy link
Member

I fixed the pr. merged

@RaiVaibhav
Copy link
Contributor Author

Hey @PatrickJS sorry for delay on this PR, got quite busy with personal and medical works.

@PatrickJS
Copy link
Member

@RaiVaibhav np. the pr was done right?

@RaiVaibhav
Copy link
Contributor Author

One use case was left, which I was not getting the time to sit - Layout should be resizable

@PatrickJS
Copy link
Member

can you make an issue for whats left so we can keep track of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[✨] Improve playground or sandbox
3 participants