-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: show selected path if block scroll in view #6079
docs: show selected path if block scroll in view #6079
Conversation
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
887ad73
to
6008d06
Compare
These two points are done |
Hey @wmertens, kindly let me know what you think about these changes Instead of using the drawer I changed the grid layout for mobile devices, I feel this is better? Recording.2024-04-02.132532.mp4 |
Hey @wmertens have a look at the comment #6079 (comment) and let me know what you feel about the changes, so that I can proceed towards completing the PR. |
Looks good! |
Thanks I will start on this again |
once this is update I'll merge it |
f910a83
to
7a83220
Compare
I fixed the pr. merged |
Hey @PatrickJS sorry for delay on this PR, got quite busy with personal and medical works. |
@RaiVaibhav np. the pr was done right? |
One use case was left, which I was not getting the time to sit - |
can you make an issue for whats left so we can keep track of it |
Fixes: #6081
In output section of playground, as per the code-block in view, show the selected path on the left side.
(Also mentioned about this change in discord, kindly close the PR is its not needed)
Overview
What is it?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why
Checklist: