Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): update the Turso integration #6110

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

xinnks
Copy link
Contributor

@xinnks xinnks commented Apr 9, 2024

update dependencies and implement updated Qwik APIs, new Turso standards and links

BREAKING CHANGE: Qwik's RequestEventBase type is used instead of RequestEventCommon; change in Turso environment variable key names

Overview

Update the Turso database integration for Qwik.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

PR updates dependencies to use latest versions of the Turso client and Qwik City in subsequent releases. It also implements updated Qwik APIs, applies new Turso standards for environment variable key names and updates documentation links.

Updates the following dependencies:

  • @libsql/client@ to @libsql/client@latest
  • @builder.io/qwik-city@1.2.13 to @builder.io/qwik-city@latest

BREAKING CHANGE: Qwik's RequestEventBase type is used instead of RequestEventCommon; change in Turso environment variable key names.

Use cases and why

qwik add turso
    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

…tegration

update dependencies and implement updated Qwik APIs, new Turso standards and links

BREAKING CHANGE: Qwik's RequestEventBase type is used instead of RequestEventCommon; change in Turso
environment variable key names
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the @

starters/features/turso/package.json Outdated Show resolved Hide resolved
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xinnks you rock

@xinnks
Copy link
Contributor Author

xinnks commented Apr 13, 2024

@gioboa You guys rock. 💪

@gioboa gioboa changed the title feat(packages/docs/src/routes/docs/integrations): update the Turso integration feat(integrations): update the Turso integration Apr 13, 2024
@gioboa gioboa merged commit a8fadf9 into QwikDev:main Apr 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants