fix(plugin/optimizer): 🐛 Enhance support for custom entry points in Vite config #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite config This commit extends the capability of Vite configuration by allowing developers to specify custom entry points. This enhancement enables the creation of libraries with custom submodules. Now, the library mode handles all possible cases for the Vite `lib.entry` field.
…ject in vite-server
|
On first glance everything looks good. It takes a custom path which is resolved, and allows for object inputs. If anyone else could review before merging. |
PatrickJS
reviewed
Apr 30, 2024
wmertens
previously requested changes
Apr 30, 2024
PatrickJS
dismissed
wmertens’s stale review
fine for now. any more should be larger refactor with tests
This was referenced May 5, 2024
[🐞] Version 1.5.3 build is broken: Cannot load native addon because loading addons is disabled
#6223
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to enhance the support for custom entry points in the Vite configuration in library mode, enabling developers to specify custom entry points and facilitating the creation of libraries with custom submodules. By extending the capability of Vite configuration, this enhancement provides flexibility and empowers developers to tailor their projects more effectively.
What is it?
Description
This PR modifies the code to allow for custom entry points in the Vite configuration (library mode). It includes updates to handle custom entry points provided in the Vite config file. This enhancement aims to address the need for developers to create libraries with custom submodules by providing a more flexible configuration option.
Use cases and why
The primary use cases for this enhancement include:
Checklist:
Issues Related:
This PR solve my own issue: #6177