Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update showcases #6198

Merged
merged 2 commits into from
May 1, 2024
Merged

docs: update showcases #6198

merged 2 commits into from
May 1, 2024
+20 −0

Conversation

mgp87
Copy link
Contributor

@mgp87 mgp87 commented May 1, 2024 •
edited
Loading

What is it?

  • Docs

Description

Added our new web page built with qwik framework

Use cases and why

  • Show Lighthouse performance gotten with Qwik

image

Update:
image

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@mgp87
Update pages.json
3432b45 
Added our new web page built with qwik
@mgp87 mgp87 changed the title Update pages.json docs: Update pages.json May 1, 2024
gioboa
gioboa requested changes May 1, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the accessibility pls?
Screenshot_20240501-144155

@gioboa gioboa changed the title docs: Update pages.json docs(showcase): update websites May 1, 2024
@gioboa gioboa changed the title docs(showcase): update websites docs: update showcases May 1, 2024
@mgp87
Copy link
Contributor Author

mgp87 commented May 1, 2024

Done!
image

Can you improve the accessibility pls? Screenshot_20240501-144155

@mgp87 mgp87 requested a review from gioboa May 1, 2024 13:57
@gioboa
Copy link
Member

gioboa commented May 1, 2024

Nice 👏 Can you run build.showcase script pls?

@PatrickJS
Copy link
Member

after you run build.showcase we can merge it

@gioboa gioboa enabled auto-merge (squash) May 1, 2024 18:44
@gioboa gioboa merged commit 5b7b30c into QwikDev:main May 1, 2024
21 checks passed
@mgp87
Copy link
Contributor Author

mgp87 commented May 2, 2024

after you run build.showcase we can merge it

Sorry, I am out of home until Sunday

@gioboa
Copy link
Member

gioboa commented May 2, 2024

Sorry, I am out of home until Sunday

I run the command for you. 😉

@mgp87
Copy link
Contributor Author

mgp87 commented May 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickJS PatrickJS PatrickJS approved these changes

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgp87 @gioboa @PatrickJS