refactor(qrlToString): v2 SyncQRLInternal type #6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJS
commented
May 18, 2024
| if (!backChannel) { | ||
| backChannel = (globalThis as any)[QRL_RUNTIME_CHUNK] = new Map(); | ||
| const isSync = isSyncQrl(value); | ||
| if (!isSync) { |
There was a problem hiding this comment.
same as before but some two comments and avoiding the work for syncQRL
PatrickJS
commented
May 18, 2024
| : ''); | ||
| return qrlString; | ||
| let qrlStringInline = `${chunk}#${symbol}`; | ||
| if (Array.isArray(value.$captureRef$) && value.$captureRef$.length > 0) { |
There was a problem hiding this comment.
refactored to check for array and use for-loop for perf
PatrickJS
commented
May 18, 2024
| $symbol$: typeof SYNC_QRL; | ||
| } | ||
|
|
||
| export type SyncQRLInternal = QRLInternal & SyncQRLSymbol; |
PatrickJS
changed the title
Varixo
approved these changes
May 18, 2024
Deploying qwik-docs with
|
| Latest commit: |
b3aa88c
|
| Status: | 🚫 Build failed. |
|
@Varixo I fixed the lint. idk how v2 tests work. is there v2 ci/cd and the errors are v1 things? if it's good can you merge? |
I think all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in v2.
add SyncQRLInternal