Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qwik-city): append cookie headers to response #6342

Merged
merged 2 commits into from
May 21, 2024

Conversation

mhuretski
Copy link
Contributor

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Qwik-city lacks ability to append cookie headers to response. See https://developer.mozilla.org/en-US/docs/Web/API/Headers/append

Use cases and why

In some cases it's valuable to be able to append cookies with the same name but different options.

MY_COOKIE=my_value; Expires=Mon, 28 May 2024 09:00:00 GMT; Path=/; Domain=my.domain.com
MY_COOKIE=my_value; Expires=Mon, 29 May 2024 10:00:00 GMT; Path=/account/; Domain=another.my.domain.com
MY_COOKIE=my_value; Expires=Mon, 30 May 2024 11:00:00 GMT; Path=/api/; Domain=.my.domain.com

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented May 20, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fd60f26

@PatrickJS
Copy link
Member

PatrickJS commented May 20, 2024

looks great. @mhuretski can you add a few tests to cookie.unit.ts

@mhuretski
Copy link
Contributor Author

@PatrickJS sure

@PatrickJS
Copy link
Member

@mhuretski you're amazing thanks for all this 🙌

@PatrickJS PatrickJS merged commit 86dcf1d into QwikDev:main May 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants