fix: fix up PrefetchServiceWorker with multiple Qwik containers #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
|
@builder.io/qwik (
|
|
LGTM, why is this draft @gioboa ? |
|
Because we are testing the fix in our POC |
|
The SW worker is fetching the remote bundles correctly |
gioboa
changed the title
Varixo
reviewed
Jun 12, 2024
| @@ -23,9 +23,21 @@ export function prefetchUrlsEventScript(prefetchResources: PrefetchResource[]) { | |||
| const data: QPrefetchData = { | |||
| bundles: flattenPrefetchResources(prefetchResources).map((u) => u.split('/').pop()!), | |||
| }; | |||
| return `document.dispatchEvent(new CustomEvent("qprefetch",{detail:${JSON.stringify(data)}}))`; | |||
| return `(${PREFETCH_BUNDLES_CODE})( | |||
| document.currentScript.closest('[q\\\\:container]'), | |||
There was a problem hiding this comment.
Why we need this? [q\\:container] is not enough?
There was a problem hiding this comment.
we need to run this in the browser to use the right one. I used the same logic we have here
PatrickJS
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why
Checklist: