Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): updated jokes to just programming ones #6469

Merged
merged 1 commit into from
Jun 10, 2024
Merged

refactor(cli): updated jokes to just programming ones #6469

merged 1 commit into from
Jun 10, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Jun 9, 2024 •
edited
Loading

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Super important change!! 😅

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@shairez shairez requested a review from a team as a code owner June 9, 2024 23:22
@netlify Netlify
Copy link

netlify bot commented Jun 9, 2024 •
edited
Loading

✅ Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 806b67a
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6666391e3df0cc000845f46d
😎 Deploy Preview https://deploy-preview-6469--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (806b67a)

npm i https://pkg.pr.new/@builder.io/qwik@6469

@builder.io/qwik-city (806b67a)

npm i https://pkg.pr.new/@builder.io/qwik-city@6469

eslint-plugin-qwik (806b67a)

npm i https://pkg.pr.new/eslint-plugin-qwik@6469

create-qwik (806b67a)

npm i https://pkg.pr.new/create-qwik@6469

@cloudflare-pages Cloudflare Pages
Copy link

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 806b67a
Status: ✅  Deploy successful!
Preview URL: https://26c928ef.qwik-8nx.pages.dev
Branch Preview URL: https://pr-jokes.qwik-8nx.pages.dev

View logs

@shairez shairez merged commit e686f6e into main Jun 10, 2024
30 checks passed
@shairez shairez deleted the pr-jokes branch June 10, 2024 00:03
gioboa
gioboa approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shairez

hamatoyogi
hamatoyogi reviewed Jun 12, 2024
View reviewed changes
packages/create-qwik/src/helpers/jokes.json
["Why couldn't the HTML list be trusted?", "There were LI's everywhere"],
["To the person who invented zero:", "Thank's for nothing!"],
["What do you call a bee that lives in America?", "A USB"],
["want about to a race conditions hear joke?", ""],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats the joke 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickJS PatrickJS PatrickJS left review comments

@hamatoyogi hamatoyogi hamatoyogi left review comments

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shairez @PatrickJS @hamatoyogi @gioboa