Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct onSubmit$ / onSubmitComplete$ type signature #6542

Merged
merged 6 commits into from
Jun 14, 2024
Merged

fix: correct onSubmit$ / onSubmitComplete$ type signature #6542

merged 6 commits into from
Jun 14, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jun 14, 2024 •
edited by PatrickJS
Loading

Overview

fixes #6541

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner June 14, 2024 01:27
@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7736e7f

@JerryWu1234 JerryWu1234 marked this pull request as draft June 14, 2024 01:34
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 14, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (7736e7f)

npm i https://pkg.pr.new/@builder.io/qwik@6542

@builder.io/qwik-city (7736e7f)

npm i https://pkg.pr.new/@builder.io/qwik-city@6542

eslint-plugin-qwik (7736e7f)

npm i https://pkg.pr.new/eslint-plugin-qwik@6542

create-qwik (7736e7f)

npm i https://pkg.pr.new/create-qwik@6542

@JerryWu1234 JerryWu1234 marked this pull request as ready for review June 14, 2024 05:21
@JerryWu1234 JerryWu1234 requested review from a team as code owners June 14, 2024 05:21
@gioboa gioboa changed the title fix: fix a ts issue fix: fix up onSubmit$ / onSubmitComplete$ signature Jun 14, 2024
gioboa
gioboa approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me @JerryWu1234

@gioboa gioboa requested a review from PatrickJS June 14, 2024 05:43
@PatrickJS
Copy link
Member

thanks, for fixing my types 😭🙏

@PatrickJS PatrickJS changed the title fix: fix up onSubmit$ / onSubmitComplete$ signature fix: correct onSubmit$ / onSubmitComplete$ type signature Jun 14, 2024
@PatrickJS PatrickJS merged commit b380973 into QwikDev:main Jun 14, 2024
21 checks passed
@PatrickJS PatrickJS mentioned this pull request Jun 14, 2024
Closed
@gioboa gioboa mentioned this pull request Jun 25, 2024
Closed
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
@JerryWu1234 @genki
fix: correct onSubmit$ / onSubmitComplete$ type signature (QwikDev#6542)
bfb488a 
* fix: fix a ts issue

* fix: fix a ts issue

* fix: fix a ts issue

* fix: fix a ts issue

---------

Co-authored-by: wuls <linsheng.wu@beantechs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickJS PatrickJS PatrickJS approved these changes

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] onSubmit$ / onSubmitComplete$ signature broken?
3 participants
@JerryWu1234 @PatrickJS @gioboa