refactor(v2/ssr-container): rename ContainerElementFrame to ElementFrame #6551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
naorpeled
changed the title
|
@naorpeled can you resolve the conflicts please? |
Sure thing |
PatrickJS
approved these changes
Jun 20, 2024
|
should openContainer and closeContainer be changed? |
naorpeled
force-pushed
the
refactor/v2/v2-ssr-container/some-renaming
branch
from
a67d371
to
6ea7260
Compare
naorpeled
force-pushed
the
refactor/v2/v2-ssr-container/some-renaming
branch
from
a67d371
to
2d3530e
Compare
naorpeled
force-pushed
the
refactor/v2/v2-ssr-container/some-renaming
branch
from
2d3530e
to
8be88e2
Compare
done. sorry for the delay. |
Great question, |
the open and closeContainer are not related to the |
|
thank you @naorpeled ! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
During a session with @mhevery and @shairez,
@mhevery said that the
Containerprefix is redundant and a bit confusing.Therefore I created this PR to remove it.
Checklist: