Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SW prefetch #6582

Merged
merged 12 commits into from
Jun 20, 2024
Merged

fix: SW prefetch #6582

merged 12 commits into from
Jun 20, 2024
+30 −17

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Jun 20, 2024 •
edited
Loading

Here is the test I've done with this code

image

@gioboa gioboa requested a review from a team as a code owner June 20, 2024 07:05
@netlify Netlify
Copy link

netlify bot commented Jun 20, 2024 •
edited
Loading

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5ab17a7

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 20, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 5ab17a7

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6582

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6582

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6582

create-qwik

npm i https://pkg.pr.new/create-qwik@6582

@gioboa gioboa linked an issue Jun 20, 2024 that may be closed by this pull request
[🐞] All bundles get prefetched with full priority in PrefetchServiceWorker resulting in error ERR_INSUFFICIENT_RESOURCES #6397
Closed
@gioboa gioboa mentioned this pull request Jun 20, 2024
Closed
@wmertens wmertens enabled auto-merge (squash) June 20, 2024 09:59
wmertens
wmertens previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gioboa gioboa disabled auto-merge June 20, 2024 10:08
@PatrickJS PatrickJS merged commit cfa1f21 into QwikDev:main Jun 20, 2024
20 checks passed
@gioboa gioboa deleted the fix/SW-prefetch branch June 20, 2024 10:33
@gioboa gioboa mentioned this pull request Jun 24, 2024
Closed
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
@gioboa @PatrickJS
@wmertens @genki
fix: SW prefetch (QwikDev#6582)
d68e245 
Co-authored-by: PatrickJS <github@gdi2290.com>
Co-authored-by: PatrickJS <github@patrickjs.com>
Co-authored-by: Wout Mertens <Wout.Mertens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickJS PatrickJS PatrickJS approved these changes

@wmertens wmertens wmertens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gioboa @wmertens @PatrickJS