fix(qrl): help rollup resolve imports from qrl segments #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
commit: @builder.io/qwik
@builder.io/qwik-city
eslint-plugin-qwik
create-qwik
|
Deploying qwik-docs with
|
| Latest commit: |
3a3558c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2444ff11.qwik-8nx.pages.dev |
| Branch Preview URL: | https://fix-dev.qwik-8nx.pages.dev |
It seems like Rollup only does its own nodejs-like resolving if a path exists on disk, even if only the filename doesn't exist. also: - mild refactor to make transformed outputs more clear - recursive rmdir => rm because of node deprecation notice - api update
PatrickJS
approved these changes
Jun 21, 2024
gioboa
approved these changes
Jun 21, 2024
genki
pushed a commit
to genki/qwik
that referenced
this pull request
Jun 28, 2024
fix(qrl): help rollup resolve imports from segments It seems like Rollup only does its own nodejs-like resolving if a path exists on disk, even if only the filename doesn't exist. also: - mild refactor to make transformed outputs more clear - recursive rmdir => rm because of node deprecation notice - api update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like Rollup only does its own nodejs-like resolving if a path exists on disk, even if only the filename doesn't exist.
also: