Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): make component entries more unique #6587

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix(optimizer): make component entries more unique #6587

merged 1 commit into from
Jun 21, 2024

Conversation

wmertens
Copy link
Member

...by adding the original filename.

This way multiple files in the same directory with the same component name won't cause problems.

@wmertens wmertens requested a review from a team as a code owner June 21, 2024 12:26
@wmertens wmertens enabled auto-merge (squash) June 21, 2024 12:26
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 00bfd92
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6675aa7bc7822000081224f3
😎 Deploy Preview https://deploy-preview-6587--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jun 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 00bfd92

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6587

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6587

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6587

create-qwik

npm i https://pkg.pr.new/create-qwik@6587

Copy link

cloudflare-pages bot commented Jun 21, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 00bfd92
Status: ✅  Deploy successful!
Preview URL: https://8f64d37b.qwik-8nx.pages.dev
Branch Preview URL: https://fix-dev.qwik-8nx.pages.dev

View logs

...by adding the original filename.

This way multiple files in the same directory with the same component name won't cause problems.
thejackshelton-kunaico

This comment was marked as duplicate.

Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fixes a needed issue in the optimizer w/ Qwik UI

@wmertens wmertens merged commit c490a95 into main Jun 21, 2024
29 checks passed
@wmertens wmertens deleted the fix-dev branch June 21, 2024 16:51
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
...by adding the original filename.

This way multiple files in the same directory with the same component name won't cause problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants