Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: manage assetsDir #6588

Merged
merged 14 commits into from
Jun 25, 2024
Merged

feat: manage assetsDir #6588

merged 14 commits into from
Jun 25, 2024

Conversation

gioboa
Copy link
Member

@gioboa gioboa commented Jun 21, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gioboa gioboa requested a review from a team as a code owner June 21, 2024 15:48
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2024 •
edited
Loading

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 871ea35

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 21, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 871ea35

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6588

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6588

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6588

create-qwik

npm i https://pkg.pr.new/create-qwik@6588

templates

@gioboa gioboa marked this pull request as draft June 21, 2024 16:32
@gioboa gioboa linked an issue Jun 22, 2024 that may be closed by this pull request
[🐞] follow up on Vite's assetsDir support #6534
Closed
4 tasks
@gioboa gioboa marked this pull request as ready for review June 22, 2024 17:07
@gioboa gioboa requested review from a team as code owners June 22, 2024 17:07
@gioboa gioboa marked this pull request as draft June 22, 2024 19:59
@gioboa gioboa marked this pull request as ready for review June 24, 2024 22:30
thejackshelton
thejackshelton approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gioboa gioboa merged commit 35aba35 into QwikDev:main Jun 25, 2024
20 checks passed
@gioboa gioboa deleted the feat/manage-assetsDir branch June 25, 2024 20:14
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
@gioboa @genki
feat: manage assetsDir (QwikDev#6588)
09c3340
@maiieul maiieul mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhevery mhevery mhevery approved these changes

@PatrickJS PatrickJS PatrickJS approved these changes

@thejackshelton thejackshelton thejackshelton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] follow up on Vite's assetsDir support
5 participants
@gioboa @mhevery @PatrickJS @thejackshelton @shairez