fix(v2): fix vnode separators #6596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varixo
commented
Jun 24, 2024
| @@ -956,7 +956,7 @@ class SSRContainer extends _SharedContainer implements ISSRContainer { | |||
| let skipCount = elementIdx - lastSerializedIdx; | |||
| // console.log('emitVNodeSeparators', lastSerializedIdx, elementIdx, skipCount); | |||
| while (skipCount != 0) { | |||
| if (skipCount >= 4096) { | |||
There was a problem hiding this comment.
@mhevery I think this is a good change. If skipCount is equal to 4096 then we want to execute code in the else block, right?
There was a problem hiding this comment.
yes, that is correct. Thank you for noticing.
Varixo
commented
Jun 24, 2024
Comment on lines
37
to
40
| ADVANCE_2048_CH: /* * */ ',', // ',' is vNodeData separator skipping 1024. | ||
| ADVANCE_2048: /* ****** */ 44, // ',' is vNodeData separator skipping 1024. | ||
| ADVANCE_4096_CH: /* * */ `.`, // `.` is vNodeData separator skipping 2048. | ||
| ADVANCE_4096: /* ****** */ 46, // `.` is vNodeData separator skipping 2048. |
There was a problem hiding this comment.
I don't know why we are missing the 45 charcode?
There was a problem hiding this comment.
That is weird! I don't think we should be skipping anything. I think that is a bug and should be fixed.
mhevery
approved these changes
Jun 24, 2024
Comment on lines
37
to
40
| ADVANCE_2048_CH: /* * */ ',', // ',' is vNodeData separator skipping 1024. | ||
| ADVANCE_2048: /* ****** */ 44, // ',' is vNodeData separator skipping 1024. | ||
| ADVANCE_4096_CH: /* * */ `.`, // `.` is vNodeData separator skipping 2048. | ||
| ADVANCE_4096: /* ****** */ 46, // `.` is vNodeData separator skipping 2048. |
There was a problem hiding this comment.
That is weird! I don't think we should be skipping anything. I think that is a bug and should be fixed.
| @@ -956,7 +956,7 @@ class SSRContainer extends _SharedContainer implements ISSRContainer { | |||
| let skipCount = elementIdx - lastSerializedIdx; | |||
| // console.log('emitVNodeSeparators', lastSerializedIdx, elementIdx, skipCount); | |||
| while (skipCount != 0) { | |||
| if (skipCount >= 4096) { | |||
There was a problem hiding this comment.
yes, that is correct. Thank you for noticing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes vnode separators and
missing refElementerror in the docs