Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): Fixed lint problem about the JSXNode #6637

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

genki
Copy link
Contributor

@genki genki commented Jul 3, 2024

Overview

I have fixed the lint issue about the serialization of th JSXNode (reported #5940)
Here is the reproduction of the issue. This code crashes.
https://stackblitz.com/edit/qwik-starter-ptzf8r?file=src%2Froutes%2Findex.tsx

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

It was needed to check the symbol name if it is the JSXNode before checking of the callable things
in order to avoid to be checked the internal structures of JSXNode and being kicked out.

Use cases and why

Relating #5940

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@genki genki requested review from a team as code owners July 3, 2024 01:21
Copy link

netlify bot commented Jul 3, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1516e28

Copy link

pkg-pr-new bot commented Jul 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 1516e28

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6637

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6637

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6637

create-qwik

npm i https://pkg.pr.new/create-qwik@6637


templates

@wmertens
Copy link
Member

wmertens commented Jul 9, 2024

can you run pnpm api.update so it doesn't have the api changes? Those get added by the build somewhere and we don't know why.

@genki
Copy link
Contributor Author

genki commented Jul 9, 2024

@wmertens
I have misunderstood about the order of execution of tasks api.update and build.full that was api.update then build.full. But the right way was inverse.
Now I did it.

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 0588230 into QwikDev:main Jul 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants