-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint): Fixed lint problem about the JSXNode
#6637
Conversation
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
commit: @builder.io/qwik
@builder.io/qwik-city
eslint-plugin-qwik
create-qwik
|
can you run |
@wmertens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
I have fixed the lint issue about the serialization of th JSXNode (reported #5940)
Here is the reproduction of the issue. This code crashes.
https://stackblitz.com/edit/qwik-starter-ptzf8r?file=src%2Froutes%2Findex.tsx
What is it?
Description
It was needed to check the symbol name if it is the
JSXNode
before checking of the callable thingsin order to avoid to be checked the internal structures of JSXNode and being kicked out.
Use cases and why
Relating #5940
Checklist: