Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): some important edge cases #6667

Merged
merged 4 commits into from
Jul 11, 2024
Merged

fix(dev): some important edge cases #6667

merged 4 commits into from
Jul 11, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jul 11, 2024 •
edited
Loading

@wmertens wmertens requested a review from a team as a code owner July 11, 2024 00:43
@netlify Netlify
Copy link

netlify bot commented Jul 11, 2024 •
edited
Loading

✅ Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit e15ff29
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/668f9f83dbe7150008b4a7f7
😎 Deploy Preview https://deploy-preview-6667--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jul 11, 2024 •
edited
Loading

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e15ff29
Status: ✅  Deploy successful!
Preview URL: https://3b0cf39c.qwik-8nx.pages.dev
Branch Preview URL: https://fix-dev.qwik-8nx.pages.dev

View logs

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 11, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: e15ff29

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6667

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6667

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6667

create-qwik

npm i https://pkg.pr.new/create-qwik@6667

templates

@wmertens
fix(dev): incorrect abs path resolutions
8a39d44 
- better heuristic for determining the full path of a requested file in dev mode
- correct transforming of qrl parent in dev mode by marking the path as absolute
- use `server` as a more correct indicator of dev mode
- pass isServer false for client build so code elimination works
@wmertens
refactor(optimizer): make is_server a regular bool
8dff75f
@wmertens wmertens requested a review from a team as a code owner July 11, 2024 09:01
@wmertens wmertens merged commit 86cccea into main Jul 11, 2024
30 checks passed
@wmertens wmertens deleted the fix-dev branch July 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shairez shairez shairez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] Client/server code splitting isn't powerful anymore since v1.7.0
2 participants
@wmertens @shairez