feat(eslint): add eslint-plugin-qwik #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@otodockal I am going to close this as we now have it implemented here: https://github.com/BuilderIO/qwik/tree/main/packages/eslint-plugin-qwik I know that you worked very hard on this, and I want to thank you for your contribution. Sorry that your work did not make it in as we have decided to go a slightly different route. But thank you. |
|
Yeah, I see @mhevery, it's OK, I could learn something new. Either way, the new API feels way more ergonomic. This rule is very strict, so it's better not to need it, definitely. |
|
Thanks for the feedback @otodockal ! (and for your contribution) 🙏 |
Deploying with
|
| Latest commit: |
cee2ad3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7bce8ff.qwik-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP
the implementation follows these spec rules https://gist.github.com/mhevery/f56cd107bd358625a0a2753eba63147a#file-spec-tsx