Process OCR files by file id #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing #112 Signed-off-by: Robin Windey <ro.windey@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
bahnwaerter
approved these changes
Aug 27, 2023
There was a problem hiding this comment.
Thanks @R0Wi for your changes. As usual, everything looks fine to me. Now, the OCR workflow should create more detailed exception messages including the filename of the problematic file during processing.
R0Wi
added a commit
that referenced
this pull request
Aug 27, 2023
Closing #112 Signed-off-by: Robin Windey <ro.windey@gmail.com>
R0Wi
added a commit
that referenced
this pull request
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #112
Testplan
cron.phpwe rename the file. OCR process should still work afterwards.Artifact
Install artifact for NC28: https://github.com/R0Wi-DEV/workflow_ocr/suites/15532932389/artifacts/886555625