big refactor #171

BobTheBob9 · 2022-05-08T23:41:47Z

No description provided.

…callbacks

BobTheBob9 · 2022-05-09T01:49:35Z

oh my fucking god does it commit the postbuild command

…_desc

GeckoEidechse

Fails connecting to any gameserver rn

GeckoEidechse · 2022-10-08T17:54:13Z

Fails connecting to any gameserver rn

Fixed with 708bfed

pg9182 · 2022-10-08T19:21:07Z

ghcr.io/pg9182/northstar-dedicated-ci:1-tf2.0.11.0-ns1.9.7-ci.59de24a5.14.3211507256-nslauncher.708bfedf.3211209264-nsmods.1804b784

pg9182 · 2022-10-09T01:54:31Z

ghcr.io/pg9182/northstar-dedicated-ci:1-tf2.0.11.0-ns1.9.7-ci.59de24a5.16.3212510647-nslauncher.b281d360.3212449064-nsmods.2637aa4e

Includes standalone datatables from @BobTheBob9. Use NS_EXTRA_ARGUMENTS=-nopakdedi (but not for sp coop). Slightly reduces the RAM usage (~10-60 MB). Eliminates the need for r2/paks/*.rpak (590MB dedi size reduction = 2GB optimized mp dedi).

pg9182

Dedicated server fails to register with the master server. Tries to add itself multiple times (it's inconsistent); the first one works, but the other ones fail and breaks the auth process.

ns-aitdm-1  | [02:09:14] [info] changing mod search path from z:\tmp\ns490603817\R2Northstar\mods\Northstar.Custom\mod to R2Northstar/mods\Northstar.CustomServers
ns-aitdm-1  | [02:09:14] [info] SERVER CodeCallback CodeCallback_PostEntityInit called
ns-aitdm-1  | [02:09:14] [info] Not executing custom callbacks for CodeCallback CodeCallback_PostEntityInit
ns-aitdm-1  | [02:09:14] [info] [SERVER SCRIPT] Code Script: _init
ns-aitdm-1  | [02:09:14] [info] loading took 15.629472999999999s
ns-aitdm-1  | [02:09:15] [error] Failed reading masterserver response: got fastify error response
ns-aitdm-1  | [02:09:15] [error] {"success":false,"error":{"enum":"DUPLICATE_SERVER","msg":"A server with this port already exists for your IP address"}}
ns-aitdm-1  | [02:09:20] [error] Failed reading masterserver response: got fastify error response
ns-aitdm-1  | [02:09:20] [error] {"success":false,"error":{"enum":"DUPLICATE_SERVER","msg":"A server with this port already exists for your IP address"}}

{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/add_server?port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&maxPlayers=12&password=","remotePort":40762},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/add_server?port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&maxPlayers=12&password=","remotePort":10064},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/add_server?port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&maxPlayers=12&password=","remotePort":64186},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/update_values?id=a4ccf7b6afe1d16288025f26fd2a0764&port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&playerCount=0&maxPlayers=12&password=","remotePort":22456},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/update_values?id=a4ccf7b6afe1d16288025f26fd2a0764&port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&playerCount=0&maxPlayers=12&password=","remotePort":40762},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/update_values?id=a4ccf7b6afe1d16288025f26fd2a0764&port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&playerCount=0&maxPlayers=12&password=","remotePort":31646},"msg":"incoming request"}

* Port ms presence reporter to std::async * Fix crash due to std::optional being assigned nullptr. * Fix formatting. * Wait 20 seconds if MS returns DUPLICATE_SERVER.

Erlite · 2022-10-12T01:13:07Z

Dedicated server fails to register with the master server. Tries to add itself multiple times (it's inconsistent); the first one works, but the other ones fail and breaks the auth process.

ns-aitdm-1  | [02:09:14] [info] changing mod search path from z:\tmp\ns490603817\R2Northstar\mods\Northstar.Custom\mod to R2Northstar/mods\Northstar.CustomServers
ns-aitdm-1  | [02:09:14] [info] SERVER CodeCallback CodeCallback_PostEntityInit called
ns-aitdm-1  | [02:09:14] [info] Not executing custom callbacks for CodeCallback CodeCallback_PostEntityInit
ns-aitdm-1  | [02:09:14] [info] [SERVER SCRIPT] Code Script: _init
ns-aitdm-1  | [02:09:14] [info] loading took 15.629472999999999s
ns-aitdm-1  | [02:09:15] [error] Failed reading masterserver response: got fastify error response
ns-aitdm-1  | [02:09:15] [error] {"success":false,"error":{"enum":"DUPLICATE_SERVER","msg":"A server with this port already exists for your IP address"}}
ns-aitdm-1  | [02:09:20] [error] Failed reading masterserver response: got fastify error response
ns-aitdm-1  | [02:09:20] [error] {"success":false,"error":{"enum":"DUPLICATE_SERVER","msg":"A server with this port already exists for your IP address"}}

{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/add_server?port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&maxPlayers=12&password=","remotePort":40762},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/add_server?port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&maxPlayers=12&password=","remotePort":10064},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/add_server?port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&maxPlayers=12&password=","remotePort":64186},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/update_values?id=a4ccf7b6afe1d16288025f26fd2a0764&port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&playerCount=0&maxPlayers=12&password=","remotePort":22456},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/update_values?id=a4ccf7b6afe1d16288025f26fd2a0764&port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&playerCount=0&maxPlayers=12&password=","remotePort":40762},"msg":"incoming request"}
{"time":"October 09 2022 02:09AM UTC","req":{"method":"POST","url":"/server/update_values?id=a4ccf7b6afe1d16288025f26fd2a0764&port=13314&authPort=13315&name=docker%209655a3f87b68%20testing%20server&description=go%20away&map=mp_colony02&playlist=aitdm&playerCount=0&maxPlayers=12&password=","remotePort":31646},"msg":"incoming request"}

Fixed by the above PR.

GeckoEidechse · 2022-10-16T23:13:50Z

There seems to be an issue where other players cannot a refactor server and just "Authentication Failed" instead...

Error on client

[2022-10-17 00:57:32.764] [error] Failed reading masterserver response: got fastify error response
[2022-10-17 00:57:32.764] [error] {"success":false,"error":{"enum":"JSON_PARSE_ERROR","msg":"Error parsing json response"}}

GeckoEidechse · 2022-10-16T23:14:48Z

Also @emma-miler seems to have an issue with Northstar not launching properly on first run after cold start.

The size check added in the refactor was incorrect: - 56306: expected pdata size based on the pdef - 512: allowance for trailing junk (r2 adds 137 bytes of trailing junk) - 100: for some wiggle room Co-Authored-By: pg9182 <96569817+pg9182@users.noreply.github.com>

player index jank

A certain someone forgot to put an `0x` in front of their hex number, meaning the offset is wrong. This would cause token to be leaked again

GeckoEidechse · 2022-10-17T20:45:06Z

GeckoEidechse · 2022-10-17T21:59:21Z

Seems like update values has some big delay on refactor not a blocking issue but should get fixed before v1.10 release.

GeckoEidechse

Apart from update values regression, I didn't notice any issues in testing with dedi docker server and around 4-8 players on Hetzner CPX21.

(Did not check code)

pg9182

No perf issues with the dedi on docker.
Wine 7.0 works for the dedi after my backported fixes.
Master server stuff works, auth works fine for both listen and dedi. Updated pdata max size is confirmed.
Some races in the master server code, but shouldn't be a problem in practice and can be fixed later.
aitdm, cp, and ttdm work fine (and the disconnect crash regression is fixed).
gamemode_fd mods branch works fine.
Dedi without rpaks for all but sp_coop seems to work fine, needs bob's latest mods commit.
Reportedly issues with delays for update_values for playercount; I'll look into that soon.
Client and server work fine with atlas.

BobTheBob9 added 3 commits May 9, 2022 00:40

use in-file macros rather than global funcs for registering dll load …

f230156

…callbacks

move more things to macros

503d336

fix debug crashes

9ab7c43

BobTheBob9 added 26 commits May 9, 2022 03:48

move sqvm funcs to sq managers

037113d

get rid of context file

77a1195

refactor some squirrel stuff and ingame compilation error message

5a58dd1

move tier0 and playlist funcs to namespaces

7a2f17c

uiscript_reset concommand: don't loop forever if compilation fails

bf56157

improve showing console for ui script compile errors

1885cae

standardise concommand func naming in c++

180470c

use lambdas for dll load callbacks so intellisense shits itself less

5ce8343

use cvar change callbacks for unescaping ns_server_name and ns_server…

44034d6

…_desc

add proper helpstrings to masterserver cvars

8b74f20

add cvar help and find

4f29baf

allow parsing of convar flags from string

5644c1a

normalise mod fs paths to be lowercase

2dba51a

move hoststate to its own file and add host_init hooks

862a115

better IsFlagSet def

035c1b1

replace files in ReadFromCache

c977118

rename g_ModManager to g_pModManager

e82d666

formatting changes

8205f96

make cvar print work on dedi, move demo fix stuff, add findflags

bd4119d

add proper map autocompletes and maps command

8a33725

formatting changes

6768e46

separate gameutils into multiple r2 headers

a526ad9

Update keyvalues.cpp

904c402

move sqvm funcs into wrappers in the manager class

3f515e0

remove unnecessary header files

93d540d

lots of cleanup and starting moving to new hooking macros

cc7b0de

GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Oct 8, 2022

This comment was marked as outdated.

Sign in to view

GeckoEidechse requested changes Oct 8, 2022

View reviewed changes

avoid ptr decay when setting auth token

708bfed

add more entity functions

b281d36

pg9182 requested changes Oct 9, 2022

View reviewed changes

Erlite mentioned this pull request Oct 11, 2022

Fix the MS server registration issues. #285

Merged

Fix the MS server registration issues. (#285)

6b09d99

* Port ms presence reporter to std::async * Fix crash due to std::optional being assigned nullptr. * Fix formatting. * Wait 20 seconds if MS returns DUPLICATE_SERVER.

emma-miler and others added 3 commits October 16, 2022 19:35

change miscserverscript to use actual entity arguments rather than

9fc8379

player index jank

Fix token clearing hook (#290)

b35a7f4

A certain someone forgot to put an `0x` in front of their hex number, meaning the offset is wrong. This would cause token to be leaked again

GeckoEidechse approved these changes Oct 17, 2022

View reviewed changes

pg9182 approved these changes Oct 17, 2022

View reviewed changes

BobTheBob9 merged commit 841881a into main Oct 17, 2022

BobTheBob9 deleted the bobs-big-refactor-pr branch October 17, 2022 22:26

GeckoEidechse mentioned this pull request Oct 21, 2022

Add guide on how to hook a new function R2Northstar/ModdingDocs#94

Open

Neoministein added a commit to Aragami-delp/NorthstarLauncherNamedPipeClient that referenced this pull request Oct 23, 2022

adapted impl based on R2Northstar#171

42bea22

GeckoEidechse mentioned this pull request Apr 22, 2023

Remove placeholder_playerdata R2Northstar/Northstar#459

Merged

Jan200101 mentioned this pull request Jun 22, 2023

undefined reference __sq_getentity #475

Closed

GeckoEidechse mentioned this pull request Oct 30, 2023

Replace static pointer offsets with structures for better readability #311

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

big refactor #171

big refactor #171

BobTheBob9 commented May 8, 2022

BobTheBob9 commented May 9, 2022

This comment was marked as outdated.

GeckoEidechse left a comment

GeckoEidechse commented Oct 8, 2022

pg9182 commented Oct 8, 2022

pg9182 commented Oct 9, 2022 •

edited

Loading

pg9182 left a comment •

edited

Loading

Erlite commented Oct 12, 2022 •

edited

Loading

GeckoEidechse commented Oct 16, 2022

GeckoEidechse commented Oct 16, 2022

GeckoEidechse commented Oct 17, 2022 •

edited

Loading

GeckoEidechse commented Oct 17, 2022

GeckoEidechse left a comment

pg9182 left a comment

big refactor #171

big refactor #171

Conversation

BobTheBob9 commented May 8, 2022

BobTheBob9 commented May 9, 2022

This comment was marked as outdated.

GeckoEidechse left a comment

Choose a reason for hiding this comment

GeckoEidechse commented Oct 8, 2022

pg9182 commented Oct 8, 2022

pg9182 commented Oct 9, 2022 • edited Loading

pg9182 left a comment • edited Loading

Choose a reason for hiding this comment

Erlite commented Oct 12, 2022 • edited Loading

GeckoEidechse commented Oct 16, 2022

GeckoEidechse commented Oct 16, 2022

GeckoEidechse commented Oct 17, 2022 • edited Loading

GeckoEidechse commented Oct 17, 2022

GeckoEidechse left a comment

Choose a reason for hiding this comment

pg9182 left a comment

Choose a reason for hiding this comment

pg9182 commented Oct 9, 2022 •

edited

Loading

pg9182 left a comment •

edited

Loading

Erlite commented Oct 12, 2022 •

edited

Loading

GeckoEidechse commented Oct 17, 2022 •

edited

Loading