Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progression system #655

Merged
merged 92 commits into from Sep 2, 2023
Merged

Progression system #655

merged 92 commits into from Sep 2, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Jun 24, 2023

TODO LIST:

  • Client side toggle for progression
  • Loadout validation on progression toggled on
  • Stat callbacks
  • Kill stats
  • Assist stats
  • Map/mode stats
  • Pilot weapon damage stats
  • Pilot weapon kill stats
  • Titan damage stats
  • Titan weapon damage stats
  • Titan weapon kill stats
  • Distance stats
  • Execution stats
  • Misc stats

EDIT: Ok so this is basically done now, just going to do some playtesting and stuff before waiting 3 months for a merge :trollface:

@ASpoonPlaysGames
Copy link
Contributor Author

TODO:

  • weapon/titan challenges tracking (we dont do this in northstar at all)
  • localisation
  • drawing attention to the button for the first time (new icon or something?)

Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good overall I only got some nitpicks
I don't know if the entire scoring thing is correct but who knows, really

ASpoonPlaysGames and others added 5 commits August 21, 2023 21:09
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
@ASpoonPlaysGames
Copy link
Contributor Author

I'm going to implement a notification thing to tell users that they can toggle it now, then I'm going to try to get a playtest going later today

@ASpoonPlaysGames
Copy link
Contributor Author

image
This is what the announcement looks like, new announcements can be easily created using the convars in the cfg. Eventually I'd like to fetch this from Atlas, but that can wait.

Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks very good, surely this will get merged soon

@ASpoonPlaysGames ASpoonPlaysGames removed the needs code review Changes from PR still need to be reviewed in code label Aug 24, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

ASpoonPlaysGames commented Aug 25, 2023

I just found AddPlayerMovementEventCallback and stuff so I'm going to rework the time and distance tracking to be better.

EDIT: nevermind, respawn made this far too complex to be worth it

@ASpoonPlaysGames
Copy link
Contributor Author

Other than caedf37 the playtest picked up no issues with the PR. With that being said I am going to remove the label and mark as ready to merge.

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested labels Aug 25, 2023
@F1F7Y F1F7Y merged commit 1d95b7d into R2Northstar:main Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants