Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace round_sas by janitor::round_half_up #127

Closed
kaz462 opened this issue Jul 25, 2023 · 0 comments · Fixed by #128
Closed

replace round_sas by janitor::round_half_up #127

kaz462 opened this issue Jul 25, 2023 · 0 comments · Fixed by #128
Assignees
@kaz462

Comments

@kaz462
Copy link
Collaborator

kaz462 commented Jul 25, 2023

@robertdevine raised a good point for using tidytlg:roundSAS instead of round_sas

Also, the current project level round_sas has this issue, although no impact on pilot3.

janitor::round_half_up has the same functionality as tidytlg:roundSAS, since janitor is already in our renv.lock file, will use janitor::round_half_up to avoid updating the lock file
@kaz462 kaz462 self-assigned this Jul 25, 2023
kaz462 added a commit that referenced this issue Jul 25, 2023
@kaz462
#127: replace round_sas by round_half_up
b713e1a
@kaz462 kaz462 linked a pull request Jul 25, 2023 that will close this issue
Closes #127: replace round_sas by round_half_up #128
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaz462 kaz462

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #127: replace round_sas by round_half_up RConsortium/submissions-pilot3-adam
1 participant
@kaz462