Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #127: replace round_sas by round_half_up #128

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

kaz462
Copy link
Collaborator

@kaz462 kaz462 commented Jul 25, 2023

@robertdevine raised a good point for using tidytlg:roundSAS instead of round_sas

Also, the current project level round_sas has this issue, although no impact on pilot3.

janitor::round_half_up has the same functionality as tidytlg:roundSAS, since janitor is already in our renv.lock file, will use janitor::round_half_up to avoid updating the lock file

  • No impact on the adsl, qc_adsl.r has the same result as before

@kaz462 kaz462 linked an issue Jul 25, 2023 that may be closed by this pull request
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@laxamanaj
Copy link
Collaborator

Thanks for checking @bms63 . I'll merge.

@laxamanaj laxamanaj merged commit bfdfe99 into main Jul 25, 2023
3 of 5 checks passed
@laxamanaj laxamanaj deleted the 127_remove_round_sas branch July 25, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace round_sas by janitor::round_half_up
3 participants