Closes #127: replace round_sas
by round_half_up
#128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robertdevine raised a good point for using
tidytlg:roundSAS
instead ofround_sas
Also, the current project level
round_sas
has this issue, although no impact on pilot3.janitor::round_half_up
has the same functionality astidytlg:roundSAS
, sincejanitor
is already in ourrenv.lock
file, will usejanitor::round_half_up
to avoid updating the lock fileadsl
,qc_adsl.r
has the same result as before