allow-warnings and allow-infos need a unit test #126
Comments
|
The weekend's starting for me, but I'll try to get something posted Monday. Apologies for the trouble. |
|
Glancing at the README, I see I missed updating the "Front-page" documentation. I'll pick that up in the resolving PR. |
ajnelson-nist
added a commit
to ajnelson-nist/pySHACL
that referenced
this issue
Feb 28, 2022
This test demonstrates the current implementation state fails. A follow-on patch will correct the issue. References: * RDFLib#126 * The general style of this test was adapted from `/test/issues/test_96.py`. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
added a commit
to ajnelson-nist/pySHACL
that referenced
this issue
Feb 28, 2022
This lets `allow_infos` to influence the `all_warn` variable appropriately. With this patch, the new `test_126.py` now passes. References: * RDFLib#126 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
added a commit
to ajnelson-nist/pySHACL
that referenced
this issue
Feb 28, 2022
This patch applies no creative input. `pyshacl -h` was run in an 80x24 window, and the command output was copy-pasted into the corresponding README section. This patch was instigated by adding the flag for `--allow-infos`. References: * RDFLib#126 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
added a commit
to ajnelson-nist/pySHACL
that referenced
this issue
Feb 28, 2022
References: * RDFLib#126 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
@ashleysommer , PRs 127 and 128 are ready for your review. When both are merged, I'm fine with closing this Issue. You had said in PR 121 that you were going to add corresponding flags with non-plural spellings. Did you still intend to do that before releasing? |
|
@ajnelson-nist |
|
@ashleysommer , I found a few cleanup matters, filed in PR 137. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR-121 was supposed to enable a result of
sh:conforms trueif onlysh:Info-level validation results were yielded. A unit test wasn't included in the PR to confirm--allow-infosworked. I also attempted to trigger--allow-warningsand didn't get an expected result. A test needs to be provided to confirm both command-line flags work.The text was updated successfully, but these errors were encountered: