Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipped namespace bindings missing/misspelled #2196

Closed
dargueta opened this issue Jan 9, 2023 · 2 comments · Fixed by #2294
Closed

Shipped namespace bindings missing/misspelled #2196

dargueta opened this issue Jan 9, 2023 · 2 comments · Fixed by #2294
Assignees
@aucampia
Labels
bug Something isn't working core Relates to core functionality of RDFLib, i.e. `rdflib.{graph,store,term}` enhancement New feature or request regression Something stopped working

Comments

@dargueta
Copy link

dargueta commented Jan 9, 2023

Version: 6.2.0

In rdflib.namespace._NAMESPACE_PREFIXES_RDFLIB there are two bugs:

  1. The prefix for DCTERMS is misspelled as "cdterms".
  2. The WGS namespace is missing.
cthoyt added a commit to cthoyt/rdflib that referenced this issue Mar 19, 2023
@cthoyt
Fix typo in NamespaceManager documentation
c6fdb31 
Prompted by RDFLib#2196
@cthoyt cthoyt mentioned this issue Mar 19, 2023
Merged
aucampia pushed a commit that referenced this issue Mar 19, 2023
@cthoyt
docs: fix typo in NamespaceManager documentation (#2291)
7a05c15 
Changed `cdterms` to `dcterms`, see <#2196> for more info.
@aucampia aucampia added regression Something stopped working bug Something isn't working labels Mar 19, 2023
@aucampia
Copy link
Member

I believe the first point has been corrected already now:

I will look into the second point, I presume this is a regression.

@aucampia aucampia self-assigned this Mar 19, 2023
@aucampia aucampia added the core Relates to core functionality of RDFLib, i.e. `rdflib.{graph,store,term}` label Mar 19, 2023
@aucampia
Copy link
Member

Regarding "The WGS namespace is missing."

I don't think we ever released a version with the wgs namespace bound, so I don't think that is strictly a bug, but we did accept a PR adding it (#1710) so we should probably have it there.

@aucampia aucampia added the enhancement New feature or request label Mar 19, 2023
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 19, 2023
@aucampia
fix: change the https://schema.org/ prefix back to schema` and add…
754500b 
… back the `wgs` binding

<RDFLib#1686> inadvertently changed prefix for
`https://schema.org/` from `schema` to `sdo` and removed the `wgs` prefix. This
PR changes the `https://schema.org/` binding back to `schema` and adds the `wgs`
binding back.

- Closes <RDFLib#2196>.
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 19, 2023
@aucampia
fix: change the https://schema.org/ prefix back to schema` and add…
282ed03 
… the `wgs` binding back

<RDFLib#1686> inadvertently changed the prefix
for `https://schema.org/` from `schema` to `sdo` and removed the `wgs` prefix.
This PR changes the `https://schema.org/` binding back to `schema` and adds the
`wgs` binding back.

- Closes <RDFLib#2196>.
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 19, 2023
@aucampia
fix: change the https://schema.org/ prefix back to schema` and add…
80a2152 
… the `wgs` binding back

<RDFLib#1686> inadvertently changed the prefix
for `https://schema.org/` from `schema` to `sdo` and removed the `wgs` prefix.
This PR changes the `https://schema.org/` binding back to `schema` and adds the
`wgs` binding back.

- Closes <RDFLib#2196>.
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 19, 2023
@aucampia
fix: change the https://schema.org/ prefix back to schema` and add…
373e5a1 
… the `wgs` binding back

<RDFLib#1686> inadvertently changed the prefix
for `https://schema.org/` from `schema` to `sdo` and removed the `wgs` prefix.
This PR changes the `https://schema.org/` binding back to `schema` and adds the
`wgs` binding back.

- Closes <RDFLib#2196>.
@aucampia aucampia mentioned this issue Mar 19, 2023
Merged
4 tasks
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 19, 2023
@aucampia
fix: change the https://schema.org/ prefix back to schema` and add…
0940997 
… the `wgs` binding back

<RDFLib#1686> inadvertently changed the prefix
for `https://schema.org/` from `schema` to `sdo` and removed the `wgs` prefix.
This PR changes the `https://schema.org/` binding back to `schema` and adds the
`wgs` binding back.

- Closes <RDFLib#2196>.
aucampia added a commit to aucampia/rdflib that referenced this issue Mar 20, 2023
@aucampia
fix: add the wgs namespace binding back
6c1d9e8 
<RDFLib#1686> inadvertently removed the `wgs` prefix.
This change adds it back.

- Closes <RDFLib#2196>.
aucampia added a commit that referenced this issue Mar 21, 2023
@aucampia
fix: add the wgs namespace binding back (#2294)
adf8eb2 
<#1686> inadvertently removed the `wgs` prefix.
This change adds it back.

- Closes <#2196>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aucampia aucampia

Labels
bug Something isn't working core Relates to core functionality of RDFLib, i.e. `rdflib.{graph,store,term}` enhancement New feature or request regression Something stopped working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add the wgs namespace binding back aucampia/rdflib
2 participants
@dargueta @aucampia