Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add the wgs namespace binding back #2294

Merged
merged 1 commit into from Mar 21, 2023
Merged

fix: add the wgs namespace binding back #2294

merged 1 commit into from Mar 21, 2023

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Mar 19, 2023 •
edited

Summary of changes

#1686 inadvertently removed the wgs prefix.
This change adds it back.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia added review wanted This indicates that the PR is ready for review ready to merge The PR will be merged soon if no further feedback is provided. labels Mar 19, 2023
@aucampia aucampia marked this pull request as ready for review March 19, 2023 18:45
@aucampia
Copy link
Member Author

Planning to merge this by 2023-03-21.

@coveralls
Copy link

coveralls commented Mar 19, 2023 •
edited

Coverage Status

Coverage: 90.782%. Remained the same when pulling 6c1d9e8 on aucampia:iwana-20230319T1901-wgs_namespace into 5a80926 on RDFLib:main.

@aucampia aucampia requested a review from a team March 19, 2023 19:36
@aucampia aucampia force-pushed the iwana-20230319T1901-wgs_namespace branch from 373e5a1 to 0940997 Compare March 19, 2023 21:33
@aucampia
Copy link
Member Author

@nicholascar it would be good to get your input here, should we change sdo back to schema?

@aucampia
Copy link
Member Author

Another related regression is:

I'm going to create a mailing list post to get some feedback.

@aucampia
Copy link
Member Author

I'm going to rework this change to only add wgs back, I guess that is not too convroversial, I'm not going to fix the https://schema.org thing without clear consensus in this discussion: https://groups.google.com/g/rdflib-dev/c/2Dg7MkldV1c.

@aucampia
fix: add the wgs namespace binding back
6c1d9e8 
<RDFLib#1686> inadvertently removed the `wgs` prefix.
This change adds it back.

- Closes <RDFLib#2196>.
@aucampia aucampia force-pushed the iwana-20230319T1901-wgs_namespace branch from 0940997 to 6c1d9e8 Compare March 20, 2023 19:26
@aucampia aucampia changed the title fix: change the https://schema.org/ prefix back to schema and add the wgs binding back fix: add the wgs namespace binding back Mar 20, 2023
ghost
ghost approved these changes Mar 21, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit adf8eb2 into RDFLib:main Mar 21, 2023
23 checks passed
@aucampia aucampia deleted the iwana-20230319T1901-wgs_namespace branch April 9, 2023 15:04
This was referenced Jul 6, 2023
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholascar nicholascar Awaiting requested review from nicholascar

@edmondchuc edmondchuc Awaiting requested review from edmondchuc

Assignees
No one assigned
Labels
ready to merge The PR will be merged soon if no further feedback is provided. review wanted This indicates that the PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shipped namespace bindings missing/misspelled
2 participants
@aucampia @coveralls