Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSTRUCT resolve with initBindings fixes #1001 #1002

Merged
merged 3 commits into from Apr 16, 2020
Merged

CONSTRUCT resolve with initBindings fixes #1001 #1002

merged 3 commits into from Apr 16, 2020

Conversation

sa-bpelakh
Copy link
Contributor

@sa-bpelakh sa-bpelakh commented Apr 14, 2020 •
edited

Addresses #1001 by defaulting to initBindings from the context during template substitution.

@coveralls
Copy link

coveralls commented Apr 14, 2020 •
edited

Coverage Status

Coverage decreased (-0.1%) to 75.792% when pulling 1dbe7ac on sa-bpelakh:1001-construct-init-bindings into 604d63e on RDFLib:master.

@sa-bpelakh
Copy link
Contributor Author

Confused about the decrease in coverage, as coverage on the one module I modified actually increased from 87 to 88%.

@nicholascar nicholascar merged commit acb9d10 into RDFLib:master Apr 16, 2020
@white-gecko white-gecko added this to the rdflib 5.0.0 milestone Apr 16, 2020
@white-gecko white-gecko added the enhancement New feature or request label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
rdflib 5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sa-bpelakh @coveralls @white-gecko @nicholascar