Add the content type 'application/sparql-update' when preparing a SPARQL update request #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…header before sending the update query to a the SPARQL update endpoint
|
Going by https://w3c.github.io/rdf-tests/sparql11/data-sparql11/protocol/index.html, might be worth updating |
|
@effigies I've done as you suggest adding to @white-gecko: since I've added to this, please could you review? |
|
@nicholascar Tnx for your updates! One thing: Given the w3C query spec the Content-Type header only needs to be set when request method is POST... |
|
@white-gecko can you please review and likely merge? Just want to make sure I, as a contributor to the PR, don't merge |
|
Could we add a test for this? |
white-gecko
approved these changes
May 1, 2020
|
Now I have contributed as well. But I think the test is the code-ification of my review result so I did approve it and will merge it. |
white-gecko
added a commit
to white-gecko/rdflib
that referenced
this pull request
May 3, 2020
This was referenced Oct 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #1021 @nicholascar
When sending a POST request to the SPARQL update endpoint, the endpoint wants to be told which type of content it'll receive in request.
Since SPARQLConnector encodes the data with UTF-8 the request library can not deduce the correct Content-Type itself. By adding it explicitly to the headers parameter, the requests library will send to request the SPARQL update endpoint understands. At least when the sparql endpoint is a GraphDB instance...
Note: Didn't find a SPARQLConnector unit test where the addition of the content type header could be validated. Skipped making one... (?)
Closes #1021