Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BNode context dicts for NT and N-Quads parsers #1108

Conversation

mwatts15
Copy link
Contributor

@mwatts15 mwatts15 commented Jun 1, 2020

Address remainder #980. Also add similar behavior for N-Quads.

- Also, updating the shared context so it works properly with
  Graph.parse
- Also, writing out BNode reference to avoid Sphinx warning
- Deleting NTParser __init__ since it doesn't do anything
@mwatts15 mwatts15 changed the title Feature/rdflib/rdflib#980 nt nquads blank node collisions BNode context dicts for NT and N-Quads parsers Jun 1, 2020
@mwatts15 mwatts15 marked this pull request as ready for review June 1, 2020 03:17
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 75.717% when pulling bf54041 on mwatts15:feature/#980-nt-nquads-blank-node-collisions into 6b5bd37 on RDFLib:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 75.717% when pulling bf54041 on mwatts15:feature/#980-nt-nquads-blank-node-collisions into 6b5bd37 on RDFLib:master.

This was referenced Jun 1, 2020
@nicholascar
Copy link
Member

Thanks @mwatts15. Funny how the test coverage decreases when all functions altered are already under test and new whole tests are added...

@nicholascar nicholascar merged commit efa2635 into RDFLib:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants